Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sphinx setup function #246

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Remove sphinx setup function #246

merged 2 commits into from
Nov 28, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Nov 28, 2023 •
edited
Loading

Close #70

@github-actions GitHub Actions
Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#98

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@scverse-bot scverse-bot mentioned this pull request Nov 28, 2023
Closed
@flying-sheep flying-sheep changed the title Let's see what happens if we remove the setup.py function Let's see what happens if we remove the sphinx setup function Nov 28, 2023
@grst
Copy link
Collaborator Author

grst commented Nov 28, 2023

Apparently we don't - We don't use recommonmark in favor of myst

@grst grst marked this pull request as ready for review November 28, 2023 14:13
@grst grst changed the title Let's see what happens if we remove the sphinx setup function Remove sphinx setup function Nov 28, 2023
@flying-sheep flying-sheep merged commit 9ec0f0d into main Nov 28, 2023
7 checks passed
@flying-sheep flying-sheep deleted the sphinx-setup-function branch November 28, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we need a setup function for building docs?
2 participants
@grst @flying-sheep