-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): pre-processing functions for dask
with sparse chunks
#2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
+ Coverage 75.25% 75.47% +0.22%
==========================================
Files 116 116
Lines 12788 12896 +108
==========================================
+ Hits 9623 9733 +110
+ Misses 3165 3163 -2
|
flying-sheep
changed the title
WIP dask support for var_mean
Support calling Feb 19, 2024
var_mean
on dask arrays containing sparse matrices
ivirshup
added
Area – Performance 🐌
Area - Out of core 💾
Working with on disk data
Area – Preprocessing 🧼
labels
Feb 20, 2024
ilan-gold
force-pushed
the
dask-sparse-mean-var
branch
3 times, most recently
from
February 27, 2024 14:06
987c7d5
to
59b3f65
Compare
ilan-gold
force-pushed
the
dask-sparse-mean-var
branch
from
February 27, 2024 14:30
f887c77
to
fd22a19
Compare
ilan-gold
changed the title
Support calling
(feat): pre-processing functions for Feb 27, 2024
var_mean
on dask arrays containing sparse matrices dask
with sparse chunks
ilan-gold
reviewed
Feb 28, 2024
ilan-gold
reviewed
Mar 18, 2024
ivirshup
reviewed
Mar 20, 2024
3 tasks
3 tasks
3 tasks
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Isaac Virshup <[email protected]>
ivirshup
approved these changes
Mar 22, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Mar 22, 2024
… with sparse chunks
ivirshup
pushed a commit
that referenced
this pull request
Mar 22, 2024
…parse chunks (#2947) Co-authored-by: Philipp A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note I did not follow:
https://gist.github.com/Intron7/bbf5058794be7b81d3953ae39c17d8b8
This is because this PR is basically very simple. I just added an
axis_sum
function for dispatching on dask arrays (with sparse chunks) which now handles the needed functionality and then it propagates up to various functions as noted in the release note:scanpy.pp.scale
,scanpy.pp.filter_cells
,scanpy.pp.filter_genes
,scanpy.pp.scale
andscanpy.pp.highly_variable_genes