Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~ 35.63% faster filtering #3330

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaushalprasadhial
Copy link
Contributor

We are submitting PR for speed up of the filtering

Time
Original 290.59
Updated 187.03
Speedup 35.63%

Experiment was done on AWS r7i.24xlarge

  • Closes #
  • Tests included or not required because:
  • Release notes not necessary because:

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 22.44898% with 38 lines in your changes missing coverage. Please review.

Project coverage is 72.25%. Comparing base (a70582e) to head (25e7cd4).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/preprocessing/_simple.py 22.44% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   76.27%   72.25%   -4.03%     
==========================================
  Files         117      111       -6     
  Lines       12795    12639     -156     
==========================================
- Hits         9760     9132     -628     
- Misses       3035     3507     +472     
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_simple.py 61.67% <22.44%> (ø)

... and 65 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant