Skip to content

fix int for shortcut #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025
Merged

fix int for shortcut #3461

merged 7 commits into from
May 21, 2025

Conversation

Intron7
Copy link
Member

@Intron7 Intron7 commented Feb 11, 2025

Fixes a bug where the regress_out short cut would error for integer dyte

@Intron7 Intron7 modified the milestones: 1.12.0, 1.11.0 Feb 11, 2025
@Intron7 Intron7 requested a review from ilan-gold February 11, 2025 12:37
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.74%. Comparing base (652cb00) to head (3903388).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/preprocessing/_simple.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3461   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files         113      113           
  Lines       12703    12709    +6     
=======================================
+ Hits         9749     9754    +5     
- Misses       2954     2955    +1     
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_simple.py 90.72% <83.33%> (-0.12%) ⬇️

@flying-sheep flying-sheep modified the milestones: 1.11.1, 1.11.2 Mar 31, 2025
@ilan-gold ilan-gold enabled auto-merge (squash) May 21, 2025 10:01
@ilan-gold ilan-gold merged commit def4f23 into main May 21, 2025
12 of 13 checks passed
@ilan-gold ilan-gold deleted the fix-int-for-regress_out branch May 21, 2025 10:12
ilan-gold added a commit that referenced this pull request May 21, 2025
* fix int for shortcut

* add release note

* add order to astype

* (fix): sparse bug + tests

---------

Co-authored-by: Philipp A. <[email protected]>
Co-authored-by: ilan-gold <[email protected]>
(cherry picked from commit def4f23)
ilan-gold added a commit that referenced this pull request May 21, 2025
* fix int for shortcut

* add release note

* add order to astype

* (fix): sparse bug + tests

---------



(cherry picked from commit def4f23)

Co-authored-by: Severin Dicks <[email protected]>
Co-authored-by: Philipp A. <[email protected]>
@scverse scverse deleted a comment from lumberbot-app bot May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants