Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiVI with Poisson/NB likelihood for ATAC? #2257

Open
vitkl opened this issue Sep 6, 2023 · 8 comments
Open

MultiVI with Poisson/NB likelihood for ATAC? #2257

vitkl opened this issue Sep 6, 2023 · 8 comments

Comments

@vitkl
Copy link
Contributor

vitkl commented Sep 6, 2023

Hi @martinkim0 and all

Similarly to #2249 by @lauradmartens would be great to have a MultiVI version with Poisson or even NB likelihood for ATAC data. How hard do you @martinkim0 think it is to add such option to MultiVI?

@canergen
Copy link
Member

canergen commented Sep 6, 2023

Hi @vitkl I'm linking @marianogabitto here as he developed multiVI and was also working on a different implementation of PoissonPeakVI. What's your opinion on this request?

@lauradmartens
Copy link
Contributor

Yes, I also think it should be relatively straightforward and also remember that @marianogabitto already had an implementation

@vitkl
Copy link
Contributor Author

vitkl commented Sep 14, 2023

Thanks for getting back to me about this! If you @marianogabitto have an implementation of this - would be great if you could share it or add it to scvi-tools (if makes sense for @canergen)

@canergen
Copy link
Member

Happy to review the PR.

@vitkl
Copy link
Contributor Author

vitkl commented Sep 14, 2023

I don't understand the implementations well enough to easily try implementing this - but I can do a PR if I see the example implementation from @marianogabitto

@canergen
Copy link
Member

I'm sorry for the confusion that was a comment to @marianogabitto to assign me the PR if he creates one.

@Juliendly
Copy link

Hi all, I am very interested in this implementation and I'm curious to know if there is any updates on it?
Thanks!

@canergen
Copy link
Member

@lauradmartens congrats on the new manuscript: https://www.biorxiv.org/content/10.1101/2024.09.19.613754v2. Any plan to continue with the Poisson MultiVI branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants