Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose fixed model and train kwargs in autotune #2203

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

martinkim0
Copy link
Contributor

  • Closes Expose model and train kwargs in autotune #2194
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature.
  • If the changes are patches for a version, I have added the on-merge: backport to x.x.x label.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.03% ⚠️

Comparison is base (0ee065e) 89.09% compared to head (8f3c66b) 89.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   89.09%   89.07%   -0.03%     
==========================================
  Files         145      145              
  Lines       11786    11791       +5     
==========================================
+ Hits        10501    10503       +2     
- Misses       1285     1288       +3     
Files Changed Coverage Δ
scvi/autotune/_tuner.py 100.00% <ø> (ø)
scvi/autotune/_manager.py 81.33% <72.72%> (-0.37%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinkim0 martinkim0 merged commit 28a8c5d into main Jul 25, 2023
5 checks passed
@martinkim0 martinkim0 deleted the autotune-kwargs branch July 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose model and train kwargs in autotune
1 participant