Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy convert for pandas 2.0 #2212

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Fix legacy convert for pandas 2.0 #2212

merged 3 commits into from
Jul 26, 2023

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Jul 26, 2023

  • Closes Legacy model convert fails because of pandas 2 #2211
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature.
  • If the changes are patches for a version, I have added the on-merge: backport to x.x.x label.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (7122eb9) 89.08% compared to head (a1af994) 89.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
+ Coverage   89.08%   89.10%   +0.01%     
==========================================
  Files         145      145              
  Lines       11810    11809       -1     
==========================================
+ Hits        10521    10522       +1     
+ Misses       1289     1287       -2     
Files Changed Coverage Δ
scvi/model/base/_utils.py 89.79% <100.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinkim0
Copy link
Contributor Author

test linux cpu prerelease

test macos cpu

test windows cpu

@martinkim0 martinkim0 merged commit ac1743b into main Jul 26, 2023
5 of 6 checks passed
@martinkim0 martinkim0 deleted the legacy-convert branch July 26, 2023 12:31
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Jul 26, 2023
martinkim0 added a commit that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy model convert fails because of pandas 2
1 participant