-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for S3 in HubModel
#2378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
+ Coverage 89.17% 89.41% +0.23%
==========================================
Files 153 153
Lines 12518 12564 +46
==========================================
+ Hits 11163 11234 +71
+ Misses 1355 1330 -25 ☔ View full report in Codecov by Sentry. |
Working. It would be good to check cache_dir exists and otherwise create it. |
pull_from_s3
for HubModel
HubModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Martin Kim <[email protected]>
pull_from_s3
method to initialize aHubModel