Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove irrelevant step from Prometheus Operator installation #2291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matskiv
Copy link

@matskiv matskiv commented Dec 20, 2024

Description of your changes:
The # Wait for webhook CA secret to be created. steps doesn't make sense for Prometheus Operator, thus I'm proposing it's removal.

Which issue is resolved by this Pull Request:
N/A

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2024
Copy link
Contributor

Hi @matskiv. Thanks for your PR.

I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 20, 2024
@matskiv
Copy link
Author

matskiv commented Dec 20, 2024

btw, contributing doc linked in the PR template and Readme doesn't exist anymore. I haven't found it, so couldn't send a PR to fix the link.
https://github.com/scylladb/scylla-operator/blob/master/.github/pull_request_template.md?plain=1#L1
https://github.com/scylladb/scylla-operator/blob/master/README.md?plain=1#L74

@tnozicka
Copy link
Member

/ok-to-test

@scylla-operator-bot scylla-operator-bot bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2024
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a copy&paste leftover, thx

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matskiv, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@tnozicka
Copy link
Member

/lgtm cancel
please update the commit message (similar to the title)

@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@tnozicka
Copy link
Member

btw, contributing doc linked in the PR template and Readme doesn't exist anymore. I haven't found it, so couldn't send a PR to fix the link.

yeah, that was too outdated so we rather removed it, but we shouldn't reference it

@matskiv
Copy link
Author

matskiv commented Dec 20, 2024

please update the commit message (similar to the title)

I'm not sure I fully understood you. The commit message matches the title already.

@rzetelskik
Copy link
Member

rzetelskik commented Dec 20, 2024

please update the commit message (similar to the title)

I'm not sure I fully understood you. The commit message matches the title already.

@matskiv thanks for the contribution!
This is about using imperative mood in the commit subject line and PR title.
https://cbea.ms/git-commit/#imperative

So changing it to something along the lines of Remove irrelevant step from Prometheus Operator installation guide should do.
This should have been mentioned in the contribution guide, if it hadn't been removed. 😉

@rzetelskik
Copy link
Member

/kind documentation
/priority important-longterm

@scylla-operator-bot scylla-operator-bot bot added kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants