-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: remove irrelevant step from Prometheus Operator installation #2291
base: master
Are you sure you want to change the base?
Conversation
Hi @matskiv. Thanks for your PR. I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
btw, contributing doc linked in the PR template and Readme doesn't exist anymore. I haven't found it, so couldn't send a PR to fix the link. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a copy&paste leftover, thx
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matskiv, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel |
yeah, that was too outdated so we rather removed it, but we shouldn't reference it |
I'm not sure I fully understood you. The commit message matches the title already. |
@matskiv thanks for the contribution! So changing it to something along the lines of |
/kind documentation |
Description of your changes:
The
# Wait for webhook CA secret to be created.
steps doesn't make sense for Prometheus Operator, thus I'm proposing it's removal.Which issue is resolved by this Pull Request:
N/A