Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0 #212

Merged
merged 260 commits into from
Sep 1, 2021
Merged

Version 4.0 #212

merged 260 commits into from
Sep 1, 2021

Conversation

bockthom
Copy link
Collaborator

@bockthom bockthom commented Sep 1, 2021

4.0

Announcement

Added

Changed/Improved

Fixed

Get the commit messsage data using the new read function and merge either nothing, the
title or message and title into the commit.data of the proj.conf instance.

See #180

Signed-off-by: Niklas Schneider <[email protected]>
Add the new attribute "commit.messages" to the project configuration class with options "none",
"title" and "message" to make it possible to specify what exactly of the commit message data
is to be merged to the commit data.

See #180

Signed-off-by: Niklas Schneider <[email protected]>
Add two tests for testing the merge functionality for both full commit messages and
titles only. Fix bug that merges message body instead of title when selecting
option "title"

See #180

Signed-off-by: Niklas Schneider <[email protected]>
Also exchange the merge attribute when merging data frames of commit
messages from commit.id to hash.

Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Niklas Schneider <[email protected]>
As commit.id was the first column of the data frame anyway,
merging has not changed the order. But when using the hash column
it is taken as the first colum of the resulting data frame.
Change the order of the columns in order to not break anything
that relies on the order.

See #180

Signed-off-by: Niklas Schneider <[email protected]>
Follow the review suggestions of @clhunsen.

See #180

Signed-off-by: Niklas Schneider <[email protected]>
Following the review of #193

Signed-off-by: Niklas Schneider <[email protected]>
Remove some empty lines and indent some lines.
Also remove commit.message.data.unprocessed variable and use the
commit.message.data variable from the beginning. Add column names
beforehand in order to enable access without indices.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Create private function update.commit.message.data in util-data.R
which handles the merge and change the location where it is
called in set.commits.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Fix an error where the value of a variable that is defined
in an if block is returned outside that if block.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Replaced a loop with a conversion from a list of vectors
in a data frame and access its columns directly

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Move functions concerning reading commit messages and the constants used
by them to a new section in util.read.
Replace subset with proper indexing and minor comment fixes.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Also adapt 'update.commit.messages' to better match the implementation
of similar methods.
Add 'set.commit.messages' in order to be able to set the commit messages
to NULL.

See #193.

Signed-off-by: Niklas Schneider <[email protected]>
Introduce new function 'format.commit.ids' in along with new section in
util-read.R. Also put format "<commit-%s>" into a constant.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Take advice by @clhunsen to replace if else cascade for rearranging columns with
better merge call.
Also modify test-data tests regarding commit messages: Row names are no longer
ignored.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Change order in 'README.md', 'util-conf.R' and 'util-data.R'
Also fix table of contents in the readme.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
See #193

Signed-off-by: Niklas Schneider <[email protected]>
Add the package in 'install.R' and a description in the 'README.md'.
Also rearrange the parameter descriptions of 'ProjectConf' to be sorted
alphabetically.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Use the new data.table package to replace do.call with data.table::rbindlist
which is faster in processing data.frames.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Niklas Schneider <[email protected]>
Remove hardcoded string formatting and replace it in tests for creating
expected data using the new function 'format.commit.ids'.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Follow @clhunsen's advice to create commit message data with an
lapply to avoid having a for-loop and an additional lapply call
afterwards

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Add check for the ProjectConf attribute 'commit.messages' before
calling 'update.commit.messages'.
Also fix a few errors in comments as well as one if condition where
the wrong attribute was checked.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
Add the getter call to the 'additional.data' list.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
See #193

Signed-off-by: Niklas Schneider <[email protected]>
Add (empty) commit message data to all data split tests in 'tests-split.R'.
Also sor the additional data sources alphabetically in the tests.

See #193

Signed-off-by: Niklas Schneider <[email protected]>
hechtlC and others added 26 commits July 30, 2021 17:14
Add new threshold calculation for network-based classifications and other small fixes

Reviewed-by: Thomas Bock <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
…source>.filtered to get.<datasource>, for commits/mails/issues. Remove reflective method invocations.

Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
…<data> and <data>.unfiltered

Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Also order the edge attributes when changing them to make a identical
check possible on two differently ordered lists.

Signed-off-by: Christian Hechtl <[email protected]>
Committed-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Read bot data and filter bots

Reviewed-by: Thomas Bock <[email protected]>
Reviewed-by: Christian Hechtl <[email protected]>
With #209 we changed the threshold calculation for network-based
classifications. But the use of the new threshold was still the old one.
So now change the classification using the new threshold so that all
authors with a centrality value greater than the threshold are
considered core. This is documented in #205.

Signed-off-by: Christian Hechtl <[email protected]>
Signed-off-by: Christian Hechtl <[email protected]>
Fix bug in author classification

Reviewed-by: Thomas Bock <[email protected]>
Fix inconsistencies in log statements

Reviewed-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
@bockthom bockthom added this to the v4.0 milestone Sep 1, 2021
@bockthom
Copy link
Collaborator Author

bockthom commented Sep 1, 2021

We are ready for version 4.0 of coronet now. Thanks to all contributors for your additions, improvements, and fixes @nlschn @JoJoDeveloping @hechtlC and also for our now logo @ChristianKaltenecker.

As everything has already been reviewed, I will merge right away.

@bockthom bockthom merged commit a656026 into master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants