Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0 #212

Merged
merged 260 commits into from
Sep 1, 2021
Merged

Version 4.0 #212

merged 260 commits into from
Sep 1, 2021
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jan 7, 2021

  1. Add functions that enable merging commit messages into data

    Get the commit messsage data using the new read function and merge either nothing, the
    title or message and title into the commit.data of the proj.conf instance.
    
    See #180
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    fdc414a View commit details
    Browse the repository at this point in the history
  2. Add new configuration option for commit messages

    Add the new attribute "commit.messages" to the project configuration class with options "none",
    "title" and "message" to make it possible to specify what exactly of the commit message data
    is to be merged to the commit data.
    
    See #180
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    5db90d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f80b24b View commit details
    Browse the repository at this point in the history
  4. Add tests for merging and fix bug when merging only titles

    Add two tests for testing the merge functionality for both full commit messages and
    titles only. Fix bug that merges message body instead of title when selecting
    option "title"
    
    See #180
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    9414357 View commit details
    Browse the repository at this point in the history
  5. Add description of changes to unversioned section of NEWS.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    359b12c View commit details
    Browse the repository at this point in the history
  6. Remove unnecessary empty lines from several files

    Also exchange the merge attribute when merging data frames of commit
    messages from commit.id to hash.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    70c8395 View commit details
    Browse the repository at this point in the history
  7. Fix a syntax error in util-read

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    89a6ea6 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Fix merging by hash instead of commit.id

    As commit.id was the first column of the data frame anyway,
    merging has not changed the order. But when using the hash column
    it is taken as the first colum of the resulting data frame.
    Change the order of the columns in order to not break anything
    that relies on the order.
    
    See #180
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    6e9147e View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Modify README and NEWS

    Follow the review suggestions of @clhunsen.
    
    See #180
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c9c7ff7 View commit details
    Browse the repository at this point in the history
  2. Rename "message.body" column to "message" everywhere

    Following the review of #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    0457dd5 View commit details
    Browse the repository at this point in the history
  3. Fix style issues and improve message processing

    Remove some empty lines and indent some lines.
    Also remove commit.message.data.unprocessed variable and use the
    commit.message.data variable from the beginning. Add column names
    beforehand in order to enable access without indices.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    7e61dcb View commit details
    Browse the repository at this point in the history
  4. Put merge functionality into own function

    Create private function update.commit.message.data in util-data.R
    which handles the merge and change the location where it is
    called in set.commits.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    8e28a1f View commit details
    Browse the repository at this point in the history
  5. Fix error when returning a variable that is not defined

    Fix an error where the value of a variable that is defined
    in an if block is returned outside that if block.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    703ab3e View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Simplify data frame creation in read.commit.messages

    Replaced a loop with a conversion from a list of vectors
    in a data frame and access its columns directly
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    7caaa8d View commit details
    Browse the repository at this point in the history
  2. Reorder functions in util read and replace special functions

    Move functions concerning reading commit messages and the constants used
    by them to a new section in util.read.
    Replace subset with proper indexing and minor comment fixes.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    8dd410c View commit details
    Browse the repository at this point in the history
  3. Fix comments in and change order in 'set.commits'

    Also adapt 'update.commit.messages' to better match the implementation
    of similar methods.
    Add 'set.commit.messages' in order to be able to set the commit messages
    to NULL.
    
    See #193.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    eb1cec8 View commit details
    Browse the repository at this point in the history
  4. Add helper function to format 'commit.id' column

    Introduce new function 'format.commit.ids' in along with new section in
    util-read.R. Also put format "<commit-%s>" into a constant.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d5c8c78 View commit details
    Browse the repository at this point in the history
  5. Change commit message merge process

    Take advice by @clhunsen to replace if else cascade for rearranging columns with
    better merge call.
    Also modify test-data tests regarding commit messages: Row names are no longer
    ignored.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    43e1894 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Change order of data sources to be alphabetical

    Change order in 'README.md', 'util-conf.R' and 'util-data.R'
    Also fix table of contents in the readme.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    70b3cb6 View commit details
    Browse the repository at this point in the history
  2. Update 'NEWS.md' with commit hashes

    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    31e0f85 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Add package 'data.table' to coronet and refactor README

    Add the package in 'install.R' and a description in the 'README.md'.
    Also rearrange the parameter descriptions of 'ProjectConf' to be sorted
    alphabetically.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a0d5e32 View commit details
    Browse the repository at this point in the history
  2. Increase perfomance of commit message read

    Use the new data.table package to replace do.call with data.table::rbindlist
    which is faster in processing data.frames.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    4c49269 View commit details
    Browse the repository at this point in the history
  3. Update my copyright notices

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    19655dd View commit details
    Browse the repository at this point in the history
  4. Fix spelling errors in 'README.md' and 'util-conf.R'

    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a36bde4 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Use new helper function in tests to format commit ids

    Remove hardcoded string formatting and replace it in tests for creating
    expected data using the new function 'format.commit.ids'.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    aab0751 View commit details
    Browse the repository at this point in the history
  2. Replace for-loop with lapply call in function to read commit messages

    Follow @clhunsen's advice to create commit message data with an
    lapply to avoid having a for-loop and an additional lapply call
    afterwards
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    0859b9a View commit details
    Browse the repository at this point in the history
  3. Fix minor comment issues and add checks before updating commit messages

    Add check for the ProjectConf attribute 'commit.messages' before
    calling 'update.commit.messages'.
    Also fix a few errors in comments as well as one if condition where
    the wrong attribute was checked.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    fc5d20f View commit details
    Browse the repository at this point in the history
  4. Initialize commit message data on RangeData-objects in 'util-split.R'

    Add the getter call to the 'additional.data' list.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    686459e View commit details
    Browse the repository at this point in the history
  5. Fix minor spelling errors

    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    613a773 View commit details
    Browse the repository at this point in the history
  6. Change all data split tests to include commit message data

    Add (empty) commit message data to all data split tests in 'tests-split.R'.
    Also sor the additional data sources alphabetically in the tests.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    98e83b0 View commit details
    Browse the repository at this point in the history
  7. Change all sliding window data tests to include commit message data

    Add (empty) commit message data to all data split tests in
    'test-split-sliding-window.R'.
    Also sort the additional data sources alphabetically in the tests.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    2e42fca View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Fix minor comment issue in 'test-split-sliding-window.R'

    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    c052dfb View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Add new cleanup functions for commit messages and synchronicity

    These functions act like cleanup.pasta, they remove rows from the data
    that are not part of a range data object anymore.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    d3bbae0 View commit details
    Browse the repository at this point in the history
  2. Fix wrong variable name in 'cleanup.synchronicity'

    Fix a copy-paste-error where a varibale name was not changed from a
    prior code snippet.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    9385084 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Add cleanup functions to NEWS.md

    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    63b6f79 View commit details
    Browse the repository at this point in the history
  2. Remove unnecassary function calls and add logging output

    Warn user when updating commit messages or synchronicity that they should
    call the corresponding cleanup method.
    Remove calls to unlist in those cleanup functions.
    Fix copy-pasted comments.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    c63a25a View commit details
    Browse the repository at this point in the history
  3. Fix regex when filtering out spaces and change data frame assignment

    Fix the regex that removes spaces at the end of a commit message.
    Change the assignment of the 'commit.message.data' data frame such that
    no new data frame is instantiated anymore.
    
    See #193
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    e1e1ba8 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Fix problems in CI pipeline for R-3.3

    Our CI pipeline does currently not work for "R-3.3" (but for all the other
    R versions in the pipeline). The reason for that is the following:
    As of 2021-01-26, there is a new version of package `memoise` (2.0.0),
    which is imported by `RSQLite`, which in turn is imported by `sqldf`.
    The new version of `memoise` imports package `cachem`, which in turn
    imports package `fastmap`. Using all these packages is not a problem per
    se, they are compatible with R 3.3.3. However, the docker container
    `r-base:3.3.3`, which we use in our pipeline "R-3.3", uses g++ version
    6.3.0-9, which contains a bug. Due to the bug in the compiler, `fastmap`
    cannot be compiled and installed in tje `r-base:3.3.3` docker container,
    letting the CI pipeline fail.
    
    To circumvent this problem but still keep "R-3.3" in our CI pipeline, we
    now use docker image `r-base:3.3.2` instead, as there is another g++
    version installed in this docker image. With that, the CI pipeline should
    succeed for "R-3.3" again.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom authored and nlschn committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    18843a8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #193 from nlschn/mydev

    Add commit message merge functionality
    
    Reviewed-by: Claus Hunsen <[email protected]>
    Reviewed-by: Thomas Bock <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    bockthom authored Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c72188e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Add more explanation to 'metrics.avg.path.length' and default values

    Make more clear what the parameters do by referring to the igraph documentation
    and add default value TRUE to parameters 'directed' and 'unconnected'.
    
    See #181
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    6bf6e40 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Add default parameters to documentation of several methods

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    de9988c View commit details
    Browse the repository at this point in the history
  2. Add function 'metrics.is.smallworld' to the metrics module

    Add function to replace manual checks for smallworldness similar to the one
    for scale freeness.
    Adapt existing comments to code style conventions and remove the ones
    mentioning manual checks for smallworldness.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    ce1f812 View commit details
    Browse the repository at this point in the history
  3. Handle error in igraph function by printing user warning instead

    Add a try clause to the 'erdos.renyi.game' function call to prevent an
    unreadable error message; print a user warning and abort the operation
    instead.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4b164be View commit details
    Browse the repository at this point in the history
  4. Fix parameter default values in metrics module

    Fix default values from vectors to their respective first element because
    of calls to 'match.arg'.
    Also correct a comment stating a wrong return value.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    f929248 View commit details
    Browse the repository at this point in the history
  5. Add check for empty network in 'metrics.hub-degree' function

    If there are no vertices in the network, print a warning and return NA
    istead of letting igraph run into an error.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    ec984f4 View commit details
    Browse the repository at this point in the history
  6. Add 'metrics.centrality' function to metrics module

    Add a function to simplify getting a data frame containing author names
    and their respective centrality values.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d3cd528 View commit details
    Browse the repository at this point in the history
  7. Add new helper function 'relations.to.authors'

    Create a new helper function to be used by 'metrix.centrality' in order
    to compute the authors from the data.sources of the networks's relations
    automatically.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d1e4413 View commit details
    Browse the repository at this point in the history
  8. Finalize 'metrics.centrality' function

    Sort entries of resulting data frame and check whether the new default value
    (that is, computing the data.source directly from the network relations)
    should be used or not.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    47a6cce View commit details
    Browse the repository at this point in the history
  9. Fix code style mishaps and rewrite function to get data.sources

    Change order of functions in 'util-networks.R'.
    The function introduced in previous commits to get the authors
    from relations now only computes the data.sources and leaves the
    author computation to its caller.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    c103c3c View commit details
    Browse the repository at this point in the history
  10. Fix typos and add character(0) check in get.data.sources.from.relations

    Check for a character(0) relation and set NA as the resulting data source.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    2cc906b View commit details
    Browse the repository at this point in the history
  11. Add changelog to NEWS.md

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9ef4ee6 View commit details
    Browse the repository at this point in the history
  12. Add tests and fix bug for 'get.data.sources.from.relations'

    Add two tests in 'test-networks.R':
    - The first one checks the data sources of a multi-network with two relations
    - The second one checks the data source of an author-network
    Fix a bug where the function would return a named vector, now it only
    returns a value vector.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    add0c74 View commit details
    Browse the repository at this point in the history
  13. Update 'NEWS.md' according to feedback

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d4ba0b5 View commit details
    Browse the repository at this point in the history
  14. Fix spelling and syntax errors in 'util-network-metrics.R'

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    a6086db View commit details
    Browse the repository at this point in the history
  15. Update smallworldness functions

    Fix minor documentation issues.
    Remove check for NA in 'metrics.is.smallworld' as it is unnecessary.
    Change error handling in 'metrics.smallworldness': Now check beforehand
    if the network is simplified and stop the execution if this is not the case.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    3737322 View commit details
    Browse the repository at this point in the history
  16. Generalize and rename 'metrics.centrality' function

    Change 'author' to 'vertex', rename parameter and rename the function
    to 'metrics.vertex.centralities'.
    Fix minor documentation issues.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    dbd9c01 View commit details
    Browse the repository at this point in the history
  17. Add missing copyright header to 'util-networks.R'

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    858537a View commit details
    Browse the repository at this point in the history
  18. Update function name in 'NEWS.md'

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    60990c6 View commit details
    Browse the repository at this point in the history
  19. Fix minor style issues in 'util-networks-metrics.R'

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    77c5d50 View commit details
    Browse the repository at this point in the history
  20. Update commit hashes in 'NEWS.md'

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    400067d View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Add checks for artifact networks and vectorize 'get.artifacts'

    As the default restrict parameter for 'metrics.centrality' depends
    on the network's vertices, add checks and correpsonding calls to
    'get.artifact' if a network contains artifact vertices.
    Vectorize 'get.artifact' in 'util-data.R' in order to be able to
    process and return artifacts from different data sources. The function
    now takes a vector of data sources (or still a single one) and
    returns all correpsonding artifacts.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    cf795f2 View commit details
    Browse the repository at this point in the history
  2. Fix errors in several comments

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    69fb2e0 View commit details
    Browse the repository at this point in the history
  3. Add another case when distinguishing network types for restriction

    Add the case that there are both authors and artifact vertices in the
    network. In this case compute the lists for both and set the restrict
    parameter to the combination of these two.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    8a7327a View commit details
    Browse the repository at this point in the history
  4. Fix documentation issue in the metrics module and remove 'print()'

    Clarify 'unconnected' parameter in 'metrics.avg.pathlength'.
    Remove debug print statements in 'util-data.R'.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    ed75a2b View commit details
    Browse the repository at this point in the history
  5. Add manual default check to 'get.artifacts'

    Now that there can be multiple values in the argument, the
    'match.arg.or.default' function shows a different behaviour. Instead of
    returning only the first element of the default vector when no argument
    is passed, it returns the whole vector.
    Add manual checks for a missing argument and set it to the first element
    in this case. Inspired from the implementation of 'match.arg.or.default'
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    c83d26f View commit details
    Browse the repository at this point in the history
  6. Change default parameter selection in 'get.artifacts'

    Replace nasty if-statement similar to 'match.arg.or.default' with
    simple trick achieving the same effect.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    70c05ec View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Add changes of 'get.artifact' to 'NEWS.md'

    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    078c6f8 View commit details
    Browse the repository at this point in the history
  2. Rename parameters inside 'get.artifacts' to plural

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    5a46ff4 View commit details
    Browse the repository at this point in the history
  3. Improve performance of 'get.artifacts'

    Replace several s- and lapply calls with a single one.
    
    See #195
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    fd767bb View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Merge pull request #195 from nlschn/mydev

    Fixes in the metrics module
    
    Reviewed-by: Christian Hechtl <[email protected]>
    Reviewed-by: Thomas Bock <[email protected]>
    bockthom authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    0d8865e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Add coronet logo to README.md

    Add a new directory 'logo' which should contain all the logo variants.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    82f9971 View commit details
    Browse the repository at this point in the history
  2. Adjust README and add config file for GH-pages website

    Use our README.md file for automatically generating a GH-pages website
    for coronet.
    
    To achieve that, a _config.yml is necessary in which we specify how the
    website should be generated.
    
    Also links in the README.md should be relative links, otherwise the
    links will only work in the README rendered on the GitHub repo, but not
    on the generated GH-pages website.
    
    In addition, also fix some outdated links, add missing section to table
    of contents, etc.
    
    Add favicon to README.md, CONTRIBUTING.md, and NEWS.md.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    dc4659e View commit details
    Browse the repository at this point in the history
  3. Add logo variants

    Add several logo variants, both in svg and png format:
    
    1. Coronet logo without font
    
    2. Coronet logo with font
    
    3. Coronet favicon
    
    4. Coronet logo without font, white background
    
    5. Coronet logo with font, white background
    
    6. Coronet logo for dark mode without font
    
    7. Coronet logo for dark mode with font
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    fdc5e67 View commit details
    Browse the repository at this point in the history
  4. Add logo svgs containing everything

    Add svg files which contain all logo variants using different tiers
    (normal, dark mode, white background, black background, etc.),
    one without font and one with font.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    752a9b3 View commit details
    Browse the repository at this point in the history
  5. Update contribution guide

    As Google now uses BigCamelCase naming convention instead of '.' as separator
    in names, just linking to Google's guide is not useful any more. So, in
    addition, add a link to Google's previous xml file containing the old naming
    conventions (which unfortunatley cannot be rendered on GitHub any more).
    
    Also add one sentence that pull requests should not only be opened against
    'dev' branch but also base on 'dev' branch.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d91059e View commit details
    Browse the repository at this point in the history
  6. Update changelog

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    b58d527 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Merge pull request #196 from bockthom/logo

    Logo & Website
    
    Special thanks to Christian Kaltenecker <[email protected]>
    
    Reviewed-by: Claus Hunsen <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    bockthom authored Mar 19, 2021
    Configuration menu
    Copy the full SHA
    bf8b331 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Add methods to get issue, mail and pr count and related counts per-au…

    …thor for issue #188
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9f9150a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7260d62 View commit details
    Browse the repository at this point in the history
  3. Add tests for issue/mail count methods for issue #188

    Tests for PRs are missing since there is no test data including PRs yet
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    139f70b View commit details
    Browse the repository at this point in the history
  4. New and improved issue handling, support for issue/pr/both counting i…

    …n all varieties one can imagine (and more)
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    eb4f649 View commit details
    Browse the repository at this point in the history
  5. Add PR event data fencing, small fixes in issue/pr handling

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    627873c View commit details
    Browse the repository at this point in the history
  6. Make data fencing properly use vector notations

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    6ff585d View commit details
    Browse the repository at this point in the history
  7. Add PRs to tests, adjust (almost) all tests to respect that

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    1e1406f View commit details
    Browse the repository at this point in the history
  8. Rename get.issues to get.issues.filtered, get.issues.unfiltered to ge…

    …t.issues to make it similar to get.commits[.filtered]
    
    Close #185.
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    b9dd94c View commit details
    Browse the repository at this point in the history
  9. Adjust NEWS.md

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    966a90d View commit details
    Browse the repository at this point in the history
  10. Fix copyright header

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    3da0297 View commit details
    Browse the repository at this point in the history
  11. Modify test data to be closer to the real world

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    98e11ab View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a566cae View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Adress reviews

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    5ba6feb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ccac665 View commit details
    Browse the repository at this point in the history
  3. Adress reviews for mail count PR

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    fcf5cee View commit details
    Browse the repository at this point in the history
  4. Adress reviews:

    * Use match.arg in get.author.issue.count and related
    * Enhance documentation of preprocess.issue.data to clarify it using the unfiltered issue data
    * Add get.issues.filtered.uncached similar to get.commits.filtered.uncached
    * Enhance issue count unit tests:
      - use "issue" relation instead of "cochange"
      - add test covering the "all" case, i.e. sums of issues.only and prs.only
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    eb919fa View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Adress reviews, add filter.issues to util-data.R

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    94a2b4f View commit details
    Browse the repository at this point in the history
  2. Adjust NEWS.md, update mail count tests

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    ffaa594 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Configuration menu
    Copy the full SHA
    d71681a View commit details
    Browse the repository at this point in the history
  2. Add issue date boxing behavior to read.issues

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    eb563d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Configuration menu
    Copy the full SHA
    6129435 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #194 from JoJoDeveloping/mail-count

    Mail count & Issue count
    
    Reviewed-by: Thomas Bock <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    Reviewed-by: Claus Hunsen <[email protected]>
    bockthom authored Apr 30, 2021
    Configuration menu
    Copy the full SHA
    9a4ccb1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Reset missing variables in NetworkBuilder and ProjectData

    See #197
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    556614c View commit details
    Browse the repository at this point in the history
  2. Add missing variable to environment reset in NetworkBuilder

    See #197
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    de091a5 View commit details
    Browse the repository at this point in the history
  3. Fix wrong documentation of 'check.value' function

    See #197
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    059b286 View commit details
    Browse the repository at this point in the history
  4. Fix misleading comment in 'get.pasta()'

    See #197
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c648574 View commit details
    Browse the repository at this point in the history
  5. Add checks to update functions to prevent warnings in special cases

    Do not print a user warning in an update function when the calling
    function on the stack corresponds to the respective cleanup function.
    
    See #197
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    e5c60a5 View commit details
    Browse the repository at this point in the history
  6. Fix some bugs regarding finding the parent function in the stacktrace

    Fix some false parentheses and add some missing assignments.
    
    See #197
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    6739619 View commit details
    Browse the repository at this point in the history
  7. Add flag and decisision to RangeData returning the right data path

    Add a flag that tells whether a RangeData object has been created
    by using codeface range data or splitting the whole dataset.
    Adapt the 'get.data.path' function to return the right data path
    depending on that flag.
    
    See #177
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    cce9527 View commit details
    Browse the repository at this point in the history
  8. Add range data flag to constructor and adapt calls in util-bulk.range

    Add the 'built.from.range.data' to the constructor of the 'RangeData'
    class which sets its private field.
    Add a getter method 'is.built.from.range.data' that returns the value of
    the private attribute.
    Adapt the calls to the constructor in 'util-bulk.R' since these are the
    only cases where the flag needs to be set true.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    917bf64 View commit details
    Browse the repository at this point in the history
  9. Fix critical typos and add test for new data path behaviour

    Fix wrong variable names and add a test that does the same setup as
    described in #177 in order to check, if the RangeData object turns out
    to have the right data path without the range folder.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    ef5bac6 View commit details
    Browse the repository at this point in the history
  10. Add a test for the data path of bulk-splitted data

    Signed-off-by: Niklas Schneider <[email protected]
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    3aa8e7d View commit details
    Browse the repository at this point in the history
  11. Adjust NEWS.md to the latest changes

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9b8b573 View commit details
    Browse the repository at this point in the history
  12. Move RangeData path tests to test-data.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    d454e5a View commit details
    Browse the repository at this point in the history
  13. Add test case to data path test and fix minor issues in test-data.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    66ad127 View commit details
    Browse the repository at this point in the history
  14. Fix critical copy paste error in util-bulk.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    6e8ab7a View commit details
    Browse the repository at this point in the history
  15. Put stacktrace length check into own function in util-misc.R

    Also fix stacktrace check in 'update.commit.message.data'.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    7927676 View commit details
    Browse the repository at this point in the history
  16. Reorder 'reset.environment' alphabetically and remove getter

    Remove unused getter for private field 'built.from.range.data' in
    'RangeData' class. Fix some typos
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9a00438 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a56a6cb View commit details
    Browse the repository at this point in the history
  18. Rename private flag of RangeData

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    169c034 View commit details
    Browse the repository at this point in the history
  19. Fix typos in NEWS.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f95b0b8 View commit details
    Browse the repository at this point in the history
  20. Change formulation in NEWS.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    83fed13 View commit details
    Browse the repository at this point in the history
  21. Restructure data path test and fix typos in util-data.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9b3e7b0 View commit details
    Browse the repository at this point in the history
  22. Add missing function description to NEWS.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c8a3b77 View commit details
    Browse the repository at this point in the history
  23. Add data path flag to constructor calls in showcase.R

    When creating new RangeData objects with the ranges from the
    ProjectConf, set the 'built.from.range.data.read' to 'TRUE' as the
    ranges that are used come are read from the disk.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    cbfcbb5 View commit details
    Browse the repository at this point in the history
  24. Fix function name typo in util-misc.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    81aded8 View commit details
    Browse the repository at this point in the history
  25. Improve documentation of new function and remove statement from test

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    e0145e2 View commit details
    Browse the repository at this point in the history
  26. Rename utility function

    Rename 'get.last.but.one.element' to 'get.second.last.element' in
    util-misc.R
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 3, 2021
    Configuration menu
    Copy the full SHA
    90394ab View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Add missing copyright header in util-misc.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 6, 2021
    Configuration menu
    Copy the full SHA
    8a6380f View commit details
    Browse the repository at this point in the history
  2. Adjust commit hashes to the latest rebased ones

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 6, 2021
    Configuration menu
    Copy the full SHA
    54e1af5 View commit details
    Browse the repository at this point in the history
  3. Add more details and commit hashes to NEWS.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed May 6, 2021
    Configuration menu
    Copy the full SHA
    eba0423 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #199 from nlschn/mydev

    Fix wrong data path issue and emerging bugs
    
    Reviewed-by: Christian Hechtl <[email protected]>
    Reviewed-by: Thomas Bock <[email protected]>
    Reviewed-by: Claus Hunsen <[email protected]>
    bockthom authored May 6, 2021
    Configuration menu
    Copy the full SHA
    321bf08 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. Remove warning assignment from test suite initialization

    As of R version 4.1, the base environment is locked and bindings to the
    base environment cannot be added or removed any more. Hence, assigning
    'last.warning' to NULL results in an error, as 'last.warning' belongs to
    the base environment.
    
    To make the test suite run also on R version 4.1, the assignment that clears
    'last.warning' ist removed. This should not affect the tests in our CI
    pipeline as ususually they are run in a new environment.
    For now, there is no possibility any more to clear previous warnings (if
    existent).
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed May 22, 2021
    Configuration menu
    Copy the full SHA
    98c5671 View commit details
    Browse the repository at this point in the history
  2. Add 'tzone' attribute to empty POSIXct vectors

    With the release of R version 4.1.0, the R developers fixed a bug with
    the 'tzone' attribute of empty POSIXct vectors. In previous R versions,
    when calling `as.POSIXct()` on an empty vector `c()` or on an `NA`
    value, no `tzone` attribute was stored, which was inconsistent as when
    calling `as.POSIXct()` on an actual value the `tzone` attribute was
    always added. Since R version 4.1.0, the `tzone` attribute is also added
    on empty vectors and `NA` values. (See also the official R news, Section
    "Changes in R 4.1.0", Subsection "Bug fixes":
    https://cran.r-project.org/doc/manuals/r-release/NEWS.html )
    
    However, this bugfix in R version 4.1.0 breakes our test suite, as in
    some situations empty date vectors are created or `NA` values are passed
    as default value for a date, but no time zone is set in these cases. As
    this leads to the failure of certain tests, the time zone needs to be
    correctly set to UTC whenever `NA` dates or empty date vectors are
    created. This is fixed by either setting the time zone attribute via
    `lubridate::with_tz` or by calling `get.date.from.string` on `NA`
    values.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed May 22, 2021
    Configuration menu
    Copy the full SHA
    09d11ab View commit details
    Browse the repository at this point in the history
  3. Add R version 4.1.0 to CI test pipeline

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed May 22, 2021
    Configuration menu
    Copy the full SHA
    6b7fb36 View commit details
    Browse the repository at this point in the history
  4. Update changelog

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed May 22, 2021
    Configuration menu
    Copy the full SHA
    db4c733 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Merge pull request #203 from bockthom/thomas-updates

    Necessary adjustments for the recently released R version 4.1
    
    Reviewed-by: Christian Hechtl <[email protected]>
    bockthom authored May 25, 2021
    Configuration menu
    Copy the full SHA
    e6f41c4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Make splitting create new configuration objects for the split data re…

    …sults, as discussed in #198
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    e82d056 View commit details
    Browse the repository at this point in the history
  2. Adjust NEWS.md

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    c45d2fa View commit details
    Browse the repository at this point in the history
  3. Incorporate reviews: Make tests test more, change NEWS.md

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    674946b View commit details
    Browse the repository at this point in the history
  4. Make split-* tests check more config values for correctness

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    be577e5 View commit details
    Browse the repository at this point in the history
  5. Increase readability of split tests

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    bfb9108 View commit details
    Browse the repository at this point in the history
  6. Remove ToDo

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    7557f4e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Remove ancient FIXME as it has been superseded

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 29, 2021
    Configuration menu
    Copy the full SHA
    f0a8c27 View commit details
    Browse the repository at this point in the history
  2. Add warning when splitting with too few data, adjust documentation fo…

    …r methods
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 29, 2021
    Configuration menu
    Copy the full SHA
    55635eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b3d8882 View commit details
    Browse the repository at this point in the history
  4. Adjust NEWS.md

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed May 29, 2021
    Configuration menu
    Copy the full SHA
    918077d View commit details
    Browse the repository at this point in the history

Commits on May 30, 2021

  1. Merge pull request #200 from JoJoDeveloping/split-clone

    Fix wrong ProjectConf after various data splittings
    
    Reviewed-by: Thomas Bock <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    bockthom authored May 30, 2021
    Configuration menu
    Copy the full SHA
    ed3c714 View commit details
    Browse the repository at this point in the history
  2. Add a separate README.md to the logo directory

    As the 'svg' files of our logo are wrongly displayed if the used font
    'Larabie Font' is not installed on a specific system, add some further
    information which font needs to be installed to correctly display the
    font in the 'svg' file.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed May 30, 2021
    Configuration menu
    Copy the full SHA
    9e6b609 View commit details
    Browse the repository at this point in the history
  3. Make URLs clickable also on the website

    Whereas URLs are automatically converted to links in Markdown pages on
    GitHub, URLs are not automatically clickable on our automatically
    generated website on GitHub pages. Hence, convert all URLs to links.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed May 30, 2021
    Configuration menu
    Copy the full SHA
    f97e5b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. Update outdated links to 'se-passau'

    As projects 'codeface' and 'codeface-extraction' have recently been migrated
    from the 'se-passau' organization to the 'se-sic' organization, the
    corresponding links to these tools are updated (but GitHub also automatically
    forwards the old links to the new organization).
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    fe2d1f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4160130 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Merge pull request #204 from bockthom/logo

    README.md for logo directory
    
    Reviewed-by: Claus Hunsen <[email protected]>
    Reviewed-by: Christian Kaltenecker <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    hechtlC authored Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f59afa0 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Add empty checks to data source getters in util-data.R

    Add an additional check whether the current data is empty to the
    present null check, to enable rereading when the data is currently
    empty.
    
    See #177
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    46dac25 View commit details
    Browse the repository at this point in the history
  2. Cut data to the range of the RangeData object on reading

    Add check for getters of main data sources that checks whether the
    instance is a RangeData object. If so, cut the read data to the range
    that is stored in the private field 'range' of the instance.
    
    See #177
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7f9394f View commit details
    Browse the repository at this point in the history
  3. Add private vectors to ProjectData containing names of read data sources

    Add private fields 'read.data.sources' and
    'read.additional.data.sources' along with a getter for each of them to
    the ProjectData class.
    The getters for the (additional) data sources will now check whether
    their respective source is already in the appropriate vector. If not, it
    will trigger the reading process and the name of the source is added to
    the vector.
    
    This is needed because there is no way to check which data sources have
    been read at a given point in time without triggering the reading
    process.
    
    See #177
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    4798869 View commit details
    Browse the repository at this point in the history
  4. Adjust data splitting to only use read data sources

    Add two functions 'get.named.data.source.list' and
    'get.named.additional.data.source.list' to the splitting module that
    handles getting only read data sources into a named list as it is
    needed by the data splitting function.
    Adjust the data splitting functions to use these new functions.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    52a3014 View commit details
    Browse the repository at this point in the history
  5. Modify ProjectData config update to not always reset environment

    The environment is now only reset when calling 'update.project.conf' or
    'set.project.conf.entry' if the parameter(s) do not concern the initial
    reading of additional data sources.
    
    See #177
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    eed45ac View commit details
    Browse the repository at this point in the history
  6. Rewrite existing 'get.cached.data.sources' function in util-data.R

    Rewrite the function so that it now takes an optional parameter
    indicating which sources should be filtered. Also check whether for
    empty data frames instead of just whether the data is 'NULL'.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    aec898e View commit details
    Browse the repository at this point in the history
  7. Use 'get.cached.data.sources' in util-split.R with new parameters

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    de1bbfe View commit details
    Browse the repository at this point in the history
  8. Add changes to NEWS.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a0b879e View commit details
    Browse the repository at this point in the history
  9. Remove wrong statements concerning old private fields

    Remove statements referring to functionality that has been removed
    because it was already existing and add missing object references.
    Also fix terribly wrong parenthesis.
    
    See #177
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6dc9d6a View commit details
    Browse the repository at this point in the history
  10. Create new function that converts a range to a bin

    Add a new function 'get.bin.from.range' in util-misc.R that takes in a
    range and converts it to a data frame holding the single bin it
    corresponds to.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6521dbc View commit details
    Browse the repository at this point in the history
  11. Try to fix bugs in the new splitting functionality

    Fix some mistakes regarding leftovers from old implementation and copy
    paste errors. Use the new function to get bins from ranges in order not
    to have three times the same code for cutting the main data sources.
    
    Signed-off-by: Niklas Schneider
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    8fd131e View commit details
    Browse the repository at this point in the history
  12. Add check for split basis data when splitting

    Get split basis data when it is not present because it is needed to
    extract the bins.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    193cadc View commit details
    Browse the repository at this point in the history
  13. Fix wrong splitting when creating RangeData objects

    Now take the data that is within the range and not the first element of
    the list of data before, within and after the range.
    Also rename the corresponding function, as it now directly splits and
    returns the data.
    
    Signed-off-by: Niklas Schneider<[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c0f6759 View commit details
    Browse the repository at this point in the history
  14. Set each data source to empty data frame from start and upon reset

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7cdad58 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    491e70c View commit details
    Browse the repository at this point in the history
  16. Replace null checks with new cached check in util-data.Replace

    As we now initialize the data emtpy and not null, all the relevant
    checks had to be adapted by using the new function unifying all those
    checks.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b49cc5d View commit details
    Browse the repository at this point in the history
  17. Fix ProjectData initialization with empty data

    Now all data are initialized properly with their corresponding empty
    data frames or lists.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    bfbc3b0 View commit details
    Browse the repository at this point in the history
  18. Add new empty case study to test data

    As empty data is now handled differently because it is read whenever we
    call a getter, we need an extra case study, where we can test things
    with no data.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    baa6473 View commit details
    Browse the repository at this point in the history
  19. Add back revisions and authors to test data and fix syntax errors

    Apparently, revisions and authors need to be present in order to run
    the programme.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6c7e52f View commit details
    Browse the repository at this point in the history
  20. Adapt equality test in test-data.R to new handling of ProjectData

    The test now operates on the empty data and the checks have been changed
    to match the new behaviour.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3ea30ec View commit details
    Browse the repository at this point in the history
  21. Fix critical bugs in get.artifacts

    1. Fix false null check on private field instead of local variable.
    2. Add length = 0 check to catch if artifacts is already 'chr(0)' when
    having empty data.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    04d1828 View commit details
    Browse the repository at this point in the history
  22. Add new parameter to get.cached.data.sources and adapt checks for splits

    When having been created by reading (Codeface) ranges, a RangeData
    object must not split data after reading as the range it is given has
    no dates associated with it, but only the name of the read range.
    
    Split the filtered data sources into a separate vector in
    'get.cached.data.sources' and add a toggle parameter for these to make
    it more consistent.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e55d088 View commit details
    Browse the repository at this point in the history
  23. Fix test failures by naming data.split rows

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6e6dae2 View commit details
    Browse the repository at this point in the history
  24. Fix critical errors in util-data.R and util.networks.R

    Remove nrow-check in ProjectData$get.artifacts() as it returns 'NULL' in
    some cases, which breaks the if condition.
    
    In 'get.sample.network', set the 'built.from.read.range.data' flag when
    creating the ProjectData object, as it uses read ranges from the test
    data.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a0fabc2 View commit details
    Browse the repository at this point in the history
  25. Fix null check in get.artifacts to prevent possible errors

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    12cf3df View commit details
    Browse the repository at this point in the history
  26. Adapt more tests to use the new empty case study in test-networks.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2714977 View commit details
    Browse the repository at this point in the history
  27. Add additional data to filtered main data when updating them

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3afb8b1 View commit details
    Browse the repository at this point in the history
  28. Add locking functionality for main data sources

    Add locks in form of a config parameter for each of commits, mails, and
    issues in the ProjectConf class.
    The getters of these main data sources will now check whether the lock
    is set before triggering a re-read.
    Exclude those new parameters from resetting the envíronment; if they
    would, it would be nonesense to have them.
    Change tests in test-networks-covariates to use the locks on issues
    because the tests expect no issues and before, the getters would read
    them anyway which lead to failures.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3821677 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    539c32e View commit details
    Browse the repository at this point in the history
  30. Add latest changes to NEWS and README

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    88737a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Fix default values in README.md

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    7de47de View commit details
    Browse the repository at this point in the history
  2. Fix errors in comments

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    302be78 View commit details
    Browse the repository at this point in the history
  3. Fix new test data and test comments and add new ProjectData equals test

    Additionally, add missing copyright header in a test file
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    c4f742d View commit details
    Browse the repository at this point in the history
  4. Fix more comments and rename variables in util-data.R and util-misc.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    543b7ab View commit details
    Browse the repository at this point in the history
  5. Fix critical copy-paste-error when merging pasta to commits

    Also change if-cascade into a switch expression in util-data.R
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    71c80f9 View commit details
    Browse the repository at this point in the history
  6. Rename local variable in split.data.time.based to clarify its purpose

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    0215bce View commit details
    Browse the repository at this point in the history
  7. Change outdate commit hashes to new ones

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    e40ffc8 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Fix comments in test-data.R

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    10b37a6 View commit details
    Browse the repository at this point in the history
  2. Add new README.md in tests folder to describe test projects

    Also add a reference to it in the _config.yml and link it in
    CONTRIBUTION.md
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    d1c39c8 View commit details
    Browse the repository at this point in the history
  3. Adjust equality tests on data objects and make them more readble

    The tests now properly configure the additional data sources and check
    their equality. This caused the read.synchronicity function to fail on
    an empty file, so add an emptyness check to ensure that the file is not
    being loaded in this case but an empty data frame is returned instead
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    f259f55 View commit details
    Browse the repository at this point in the history
  4. Change behaviour when commit messages config parameter is changed

    Changing the parameter "commit.messages" will now trigger
    an update of the commit message data, meaning, that exactly the columns
    that are selected are present in commits and filtered commits.
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    67e11f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Update additional data sources when their respective config changes

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    ffdc954 View commit details
    Browse the repository at this point in the history
  2. Add checks in update functions to enable additional data to be reset

    Add checks to update.pasta.mails, -commits, update.synchronicity and
    -commit.messages that ensure that the respective columns in the main
    data sources are reset and not merged again, when the config parameter
    has been set to 'FALSE' ('none' for commit messages).
    
    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    eea4baf View commit details
    Browse the repository at this point in the history
  3. Reset synchronicity if time window has changed and data is cached

    Signed-off-by: Niklas Schneider <[email protected]>
    nlschn committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    73009d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Merge pull request #201 from nlschn/mydev

    Enable to read data at every point in time
    
    Reviewed-by: Thomas Bock <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    bockthom authored Jul 19, 2021
    Configuration menu
    Copy the full SHA
    ac31611 View commit details
    Browse the repository at this point in the history
  2. Update showcase.R: Remove and update outdated function calls

    - There is no function `get.network.conf.variable` in the NetworkBuilder class.
      Instead, use `get.network.conf.entry`.
    
    - The functions `get.author.class.activity` and
    `get.author.class.activity.overview` have already been removed from coronet a
    long time ago (in version 3.5, see 61b344a).
    
    - The parameter `data` of function `get.author.class.by.type` has already been
      renamed to `proj.data` a long time ago (in version 3.5, see
      587ef99).
    
    - When updating edge attributes in the NetworkConf, the edge attributes are
      specified as a vector, not as a list.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    473c094 View commit details
    Browse the repository at this point in the history
  3. Update showcase.R: Fix motif identification

    The `motifs.count` function takes a `motifs` parameter containing a list of
    motifs instead of separate parameters for different motifs. This has already
    been changed in version 3.0 of coronet (see
    f3876dc). Fix the outdated function call in the
    showcase.R file.
    
    In addition, as the specified motifs are defined on undirected networks, the
    network `g` which is passed to the `motifs.count` function needs to undirected,
    too. Therefore, update the network configuration accordingly before building the
    multi-network `g`.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    287fbfa View commit details
    Browse the repository at this point in the history
  4. Update showcase.R: Add examples for recently introduced functionality

    Add example statements on how to retrieve commit messages or synchronicity data
    on ProjectData or RangeData objects.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    0a5cce4 View commit details
    Browse the repository at this point in the history
  5. Fix inconsistenies in comments

    Fix inconsistent function documentation which I stumbled over while updating the
    showcase file.
    
    In addition, as all the optional example statements in the showcase.R are stated
    as a comment, also do this for EDCPTD-related example statements, for
    consistency reasons.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    3393cae View commit details
    Browse the repository at this point in the history
  6. Fix logging statement when printing a Conf object

    When printing a Conf object, the info "Network configuration:" was printed in
    the first line. However, this is actually wrong as this print function is used
    from both the `NetworkConf` and the `ProjectConf` object, as well as the `Conf`
    class itself. To avoid printing wrong information and also to avoid code
    duplication, just print "Configuration:" from now on, as the `Conf` class does
    not know which actual class the object at which this function is called belongs
    to.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    2077e6e View commit details
    Browse the repository at this point in the history
  7. Fix generation of Codeface range directory names

    Directory names for Codeface ranges can be generated via revision names or
    commit hashes. If commit hashes are used (which are 40 characters long),
    Codeface only uses the first 6 characters in the directory names. This was
    already implemented correctly, but the check has used the wrong function: To
    check if the revision name is 40 characters long, use the `nchar` function
    instead of the `length` function (as the latter always returns 1 in this case).
    This is a follow-up commit for b3e2947, which
    has already been introduced with version 3.5 of coronet.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5c90d1c View commit details
    Browse the repository at this point in the history
  8. Fix plotting an empty network

    If an empty network is passed to the plot function `plot.network`, vertex
    attributes `kind` and `vertex.type` have not been present in the created empty
    network. As both attributes are used during the plotting function, this lets
    plotting an empty network fail. This commit adjusts the plotting function such
    that we can plot empty networks without any errors.
    
    In addition, fix a wrong comment in function `add.attributes.to.network`.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    03f986d View commit details
    Browse the repository at this point in the history
  9. Reset environment when setting a network configuration entry.

    The description of the function `set.network.conf.entry` in the NetworkBuilder
    class already stated that the environment will be reset. However, the function
    actually did not perform the reset.
    Therefore, this commit adds the missing function call to reset the environment.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    fc4c086 View commit details
    Browse the repository at this point in the history
  10. Fix bug in issue-related add.vertex.attribute.issue.* functions

    When not passing a specific value for parameter `issue.type` to all the
    `add.vertex.attribute.issue.*` functions, the vector `c("all", "pull.requests",
    "issues")` is automatically used as default. However, as only one of the
    vector's elements is allowed, this leads to problems when passing this parameter
    to other functions in turn. To fix this, add some missing `match.arg` calls that
    make sure that only one value (the actual default "all") is used for the
    `issue.type` parameter.
    
    This is a follow-up commit for PR #194 and commit
    eb4f649.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5eb7161 View commit details
    Browse the repository at this point in the history
  11. Fix erroneous function calls in the ProjectData class

    Within functions `set.project.conf.entry` and `update.project.conf`, the
    synchronicity data is updated via calling the setter and the getter for the
    synchronicity data. As both getter and setter are public functions onf the
    ProjectData class, calling `private$...` does not work. Instead, we have to use
    `self$...`, which holds for public functions.
    
    This is a follow-up commit for PR #201 and commit
    73009d9.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    f146e9b View commit details
    Browse the repository at this point in the history
  12. Reduce amount of multiple calls to 'update.synchronicity.data()'

    When resetting a ProjectConf entry that is related to the synchronicity data,
    the corresponding update function is called. However, sometimes, the update
    function is called multiple times when synchronicity data is already cached:
    - The setter calls the update function (if synchronicity is configured).
    - The getter calls the update function (if synchronicity is configured).
    - The update function is called manually.
    So, the manual function call is not necessary if the getter was already called
    before (and both synchronicity data is configured and cached).
    
    This is another follow-up commit for PR #201 and commit
    73009d9.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    bba7376 View commit details
    Browse the repository at this point in the history
  13. Update changelog

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a77becd View commit details
    Browse the repository at this point in the history
  14. Update pull-request template to not forget about updating the showcas…

    …e file
    
    Also add a corresponding statement to the contribution guide.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5e54399 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Fix erroneous function call to update commit-message data

    As `update.commit.message.data()` is a private function, we need to call
    `private$update.commit.message.data()`.
    
    This is another follow-up commit for PR #201.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    19792cd View commit details
    Browse the repository at this point in the history
  2. Fix corner-case in function 'construct.ranges'

    When only 2 revisions are provided to the function `construct.ranges`
    via parameter `revs` and `sliding.window` was `TRUE`, then `offset + 1`
    exceeds the number of elements in `revs`, resulting in choosing elements
    `3:2` as end elements of ranges. Instead of just constructing one range,
    two ranges are constructed, which is obviously wrong. To prevent this, a
    check is added whether `offset + 1` exceeds the length of `revs` and if
    so, just return the last element to just construct one range.
    
    In addition, as we are already handling corner cases, add a check at the
    beginning of the function for checking whether, at least, two revisions
    are specified. If there is only one revision given, no range can be
    constructed, and therefore throw an error in this situation.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    000314b View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Add package 'reshape2' to install script

    As module `util-plot-evolution.R` uses the `melt` function from package
    `reshape2`, we need to add this package to the install script in order
    to install this package properly.
    
    This has been overlooked in PR #175.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    7bb4e7b View commit details
    Browse the repository at this point in the history
  2. Fix bugs in function 'metrics.vertex.centralities'

    The function `metrics.vertex.centralities` contained a lot of bugs since
    it has been introduced in PR #195.
    
    - `get.authors.by.data.source` is a public function of `ProjectData`
      and, therefore, needs to be called on a data object instead of providing
      the data object as parameter.
    - `get.artifacts` also needs to be called on a data object.
    - If both network and data are provided, but the network has either no
      vertex or no edge, the previous implementation caused errors. Therefore,
      add a check whether the network is empty before accessing vertex
      information.
    - When ordering the centrality values, use the constant
      `VERTEX.CENTRALITIES.COLUMN.NAMES` instead of accessing columns by using
      outdated column names.
    - Fix inconsistent indentation.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    e7182e7 View commit details
    Browse the repository at this point in the history
  3. Remove warning assignment from showcase.R

    As already done in commit 98c5671 for test
    suite initializiation, we also need to remove the warning assignment from the
    showcase file, as results in an error from R version 4.1 on.
    For more details on that, see 98c5671.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    03aadac View commit details
    Browse the repository at this point in the history
  4. Make showcase file runnable for CI

    To be able to use the showcase file in our CI pipeline, the following
    changes to the showcase file are done:
    
    (1) Uncomment all the statements to execute them automatically.
    
    (2) Use project "test" from the test data as default, as the test data
        is part of the repository and, therefore, acessible within the CI
        pipeline. (The recommendation to use project BusyBox still is part
        of the showcase file, but commented out.)
    
    (3) Adjust some of the statements which relied on certain
        characteristics of BusyBox such that they are executed differently
        for projects BusyBox and test data.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3eb31d8 View commit details
    Browse the repository at this point in the history
  5. Add second pipeline for showcase file to CI pipeline

    Now we have two pipelines, one for the test suite and one for running
    the showcase file. Each of these pipelines has a separate step for each
    of the supported R versions.
    
    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    719a4f0 View commit details
    Browse the repository at this point in the history
  6. Update changelog again

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3b6e562 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #207 from bockthom/thomas-updates

    Update showcase.R and add minor bug fixes
    
    Reviewed-by: Christian Hechtl <[email protected]>
    hechtlC authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    699b38e View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Fix cloning in data tests to use deep clones

    When updating the data tests to use deep clones, the comparison of two
    Conf objects brakes. This happens since a conf parameter gets a new
    field 'value' when updated. When this parameter is then changed back to
    the default value, this value field stays present. But since we compare
    Conf objects with the comparison of their string representation, this
    now brakes. The fix is to delete the 'value' field when the parameter is
    set to default.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d75373a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Add different author classification threshold

    When classifying authors into core and peripheral groups using
    network-based metrics, we now use the 80% quantile as threshold
    instead of the sum-based threshold.
    Fix tests related to this.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5128252 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Add changes from review by @bockthom

    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    b3b2c91 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Add further count-based classification metrics

    The count-based classification metrics `mail.count`, `issue.count`,
    `issue.comment.count`, `issue.commented.in.count`, and
    `issue.created.count` can now be used for the classification of
    authors into core and peripheral groups as according to #70 .
    Add further tiny fixes.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    d7b2455 View commit details
    Browse the repository at this point in the history
  2. Add tests for new count-based classification metrics

    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    32c277c View commit details
    Browse the repository at this point in the history
  3. Add documentation to undocumented methods

    Add roxygen skeleton comments to the uncommented methods in
    util-core-peripheral.R as according to #70.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a3d5ca7 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Add further changes from review by @bockthom

    - Add `mail.thread.count` to the list of possible classification metrics
    and add a test for that
    - Rename `CLASSIFICATION.METRIC.TO.TYPE` to
    `CLASSIFICATION.TYPE.TO.CATEGORY` as this fits better. Also change the
    corresponding parameter names in the functions the category is passed to
    - Change `$` notation to bracket notation as according to the coding
    conventions
    - Fix documentation errors and add missing documentation
    
    All of these fixes and changes are made according to #70.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    6f737c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Add entries in the changelog for the pull request

    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    1ec501e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #209 from hechtlC/master

    Add new threshold calculation for network-based classifications and other small fixes
    
    Reviewed-by: Thomas Bock <[email protected]>
    bockthom authored Jul 30, 2021
    Configuration menu
    Copy the full SHA
    99fdb01 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. First steps in bot filtering: Add read method, add test file, add fil…

    …tering functionality
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    838855f View commit details
    Browse the repository at this point in the history
  2. Preliminary draft of bot filtering

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    dcce82d View commit details
    Browse the repository at this point in the history
  3. Ignore the deleted user when reading in issues/PRs

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    1a08140 View commit details
    Browse the repository at this point in the history
  4. Make everything use get.mails.filtered() instead of get.mails(); fix …

    …tests
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    edf19cf View commit details
    Browse the repository at this point in the history
  5. Rename get.<datasource> to get.<datasource>.unfiltered, and get.<data…

    …source>.filtered to get.<datasource>, for commits/mails/issues. Remove reflective method invocations.
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    e05f344 View commit details
    Browse the repository at this point in the history
  6. Fix Bug in util-split.R

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    345433e View commit details
    Browse the repository at this point in the history
  7. Rename data fields in util-data.R from <data>.filtered and <data> to …

    …<data> and <data>.unfiltered
    
    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    78158ce View commit details
    Browse the repository at this point in the history
  8. Address reviews

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    8fff2d3 View commit details
    Browse the repository at this point in the history
  9. Add test for bot reading

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    84b922a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Configuration menu
    Copy the full SHA
    24c222a View commit details
    Browse the repository at this point in the history
  2. Make last commit appear in NEWS.md, fix remaining bugs

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    c97b3a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Address reviews, round 4: Small fixes for consistency

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    25ee63d View commit details
    Browse the repository at this point in the history
  2. Fix bug that causes warning message for conf updates

    Also order the edge attributes when changing them to make a identical
    check possible on two differently ordered lists.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    Committed-by: Johannes Hostert <[email protected]>
    hechtlC authored and JoJoDeveloping committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    87eaed3 View commit details
    Browse the repository at this point in the history
  3. Review, round 5: very small fix

    Signed-off-by: Johannes Hostert <[email protected]>
    JoJoDeveloping committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    1c97ec5 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #206 from JoJoDeveloping/filter-bots

    Read bot data and filter bots
    
    Reviewed-by: Thomas Bock <[email protected]>
    Reviewed-by: Christian Hechtl <[email protected]>
    bockthom authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    afb0ec0 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Fix bug in author classification

    With #209 we changed the threshold calculation for network-based
    classifications. But the use of the new threshold was still the old one.
    So now change the classification using the new threshold so that all
    authors with a centrality value greater than the threshold are
    considered core. This is documented in #205.
    
    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    0d6a3a1 View commit details
    Browse the repository at this point in the history
  2. Update NEWS.md

    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    95efe90 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #210 from hechtlC/master

    Fix bug in author classification
    
    Reviewed-by: Thomas Bock <[email protected]>
    bockthom authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    b17a1e0 View commit details
    Browse the repository at this point in the history
  4. Update and sort parts of the README.md

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    564208b View commit details
    Browse the repository at this point in the history
  5. Update README and CI pipeline regarding R-versions

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    335fc9a View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Fix inconsistencies in log statements

    Signed-off-by: Christian Hechtl <[email protected]>
    hechtlC committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8ca83f0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #211 from hechtlC/master

    Fix inconsistencies in log statements
    
    Reviewed-by: Thomas Bock <[email protected]>
    bockthom authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    17f1e60 View commit details
    Browse the repository at this point in the history
  3. Streamline changelog prior to next release

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    51a82fd View commit details
    Browse the repository at this point in the history
  4. Version 4.0

    Signed-off-by: Thomas Bock <[email protected]>
    bockthom committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    bb8cd05 View commit details
    Browse the repository at this point in the history