Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the 3D mesh and occupancy grid generation #11

Open
argenos opened this issue Jun 19, 2024 · 2 comments · May be fixed by #20
Open

Refactor the 3D mesh and occupancy grid generation #11

argenos opened this issue Jun 19, 2024 · 2 comments · May be fixed by #20
Assignees

Comments

@argenos
Copy link
Member

argenos commented Jun 19, 2024

This should be moved to the scenery_builder.

@argenos argenos self-assigned this Jun 19, 2024
@argenos
Copy link
Member Author

argenos commented Jun 21, 2024

Based on the contents of the composable model representation, this requires #10 to be solved first

@argenos
Copy link
Member Author

argenos commented Aug 22, 2024

These modifications should also be moved to the scenery builder (if they are still necessary):

# Modifications to the vertices made to avoid face clashing
threshold = 0.01
modifications = np.where(origin[2] == vertices[:, 2], -threshold, 0)
modifications += np.where(self.wall_a.height == vertices[:, 2], threshold, 0)
if not self.wall_b is None:
modifications += np.where(
self.wall_b.height == vertices[:, 2], threshold, 0
)
modifications = np.hstack(
(
np.zeros((len(modifications), 2)),
modifications.reshape((len(modifications), 1)),
)
)
vertices = vertices + modifications
vertices[:, 1] -= threshold
new_vertices = np.copy(vertices)
new_vertices[:, 1] += self.thickness + threshold * 2

@argenos argenos linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant