-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor floorplan grammar #17
Open
argenos
wants to merge
93
commits into
devel
Choose a base branch
from
refactor-floorplan-grammar
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argenos
force-pushed
the
refactor-floorplan-grammar
branch
from
July 26, 2024 15:05
1fda262
to
a399203
Compare
This uses the variation template to generate a new floorplan model
This also refactors the v1->v2 template to use a base fpm template
This commit also: - Add example of manually specified model for v2 - Updates the variation model to use the floorplan v2 model
argenos
force-pushed
the
refactor-floorplan-grammar
branch
from
July 30, 2024 12:02
a399203
to
8626cd3
Compare
Samuel-Wiest
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are documented in
docs/v2-motivation.md
. As a very short summary, not exhaustive and in no particular order:exce_floorplan
tofloorplan_dsl
v2
by concern: semantics, validation and scoping have their own modules.v1
is still included in this repository until it can be fully deprecated (e.g. Refactor the 3D mesh and occupancy grid generation #11 has also been closed).v1
models tov2
using Jinja templatestextx generate models/examples/hbrs.floorplan --target floorplan-v2 -o models/examples --overwrite
v2
coordinates.json
to follow the schema in the kinova modelsdocs
folder to allow GH pages to see and use them.coordinates.json
to use the appropriate QUDT units (i.e.DEG
instead ofdegrees
)Note that the blender export won't work any more (it is untested) but will be removed soon from this repository (see #11 )