fix: Vulnerability fix for starkbank-ecdsa 2.2.0 dependency #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranjanprasad1996
changed the title
|
@tiwarishubham635 should this be merged? |
|
I see some tests are failing |
|
@tiwarishubham635 Have fixed the tests. Could you please retrigger the builds? |
|
@tiwarishubham635 When will this patch be released? Thanks |
|
We will be releasing today. Thanks! |
8 tasks
wfriedl
reviewed
May 19, 2025
| from ellipticcurve.publicKey import PublicKey | ||
| from ellipticcurve.signature import Signature | ||
|
|
||
| from .eventwebhook_header import EventWebhookHeader |
There was a problem hiding this comment.
Removing EventWebhookHeader breaks eventwebhook_example.py
|
I think we can export the EventWebhookHeader from eventwebhook init.py to fix this |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
As part of the quay.io vulnerability report, it is reported that the
sendgrid-python==6.11.0package has a vulnerability (GHSA-9wx7-jrvc-28mm) reported for dependencystarkbank-ecdsa==2.2.0which is the latest version available from 2022 (The starbank repository no longer seems to be maintained).This PR solves replaces the outdated starbank-ecdsa library (https://github.com/starkbank/ecdsa-python) with an actively mainained library ecdsa (https://github.com/tlsfuzzer/python-ecdsa).
Checklist