Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Try CPM #161

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[INFRA] Try CPM #161

merged 1 commit into from
Nov 9, 2023

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Nov 6, 2023

  • Todo: update readme
  • use cpm download script,
    • but include actual cpm in cpack source package (?)
  • gtest/benchmark
  • robin_hood? Not maintained, better to keep here for fixes
  • define dependencies and their versions in one place
  • is CPM's SYSTEM option sufficient? (yes, with cmake >= 3.25)
  • use CPMFindPackage instead of CPMAddPackage and remove changing default CPM_USE_LOCAL_PACKAGES would be unconfigurable to do non-local

Simde is also multiple MiB big, so being able to use a package for that dramatically reduces our library size when installed

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 1:18pm

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab2dc4b) 99.94% compared to head (54bc94a) 99.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          45       45           
  Lines        1796     1796           
=======================================
  Hits         1795     1795           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
Copy link
Member Author

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check SIMDE_ENABLE_OPENMP

cmake/install.cmake Outdated Show resolved Hide resolved
cmake/install.cmake Outdated Show resolved Hide resolved
cmake/install.cmake Outdated Show resolved Hide resolved
cmake/install.cmake Show resolved Hide resolved
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
@seqan-actions seqan-actions removed the lint [INTERNAL] used for linting label Nov 8, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
@eseiler eseiler marked this pull request as ready for review November 8, 2023 18:55
cmake/configuration.cmake Outdated Show resolved Hide resolved
cmake/configuration.cmake Outdated Show resolved Hide resolved
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 9, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 9, 2023
@eseiler eseiler merged commit 59ee724 into seqan:main Nov 9, 2023
27 checks passed
@eseiler eseiler deleted the infra/cpm branch November 9, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants