Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround compiling with debug mode #3222

Merged
merged 3 commits into from
Jan 17, 2024
Merged

fix: workaround compiling with debug mode #3222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c776fe
fix: workaround compiling with debug mode
SGSSGene Jan 15, 2024
b864f72
Patch: improve readability of std::vector debug mode fix
SGSSGene Jan 17, 2024
3322897
doc: add example of the underlying issue of the workaround
SGSSGene Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/seqan3/core/platform.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,14 @@ static_assert(sdsl::sdsl_version_major == 3, "Only version 3 of the SDSL is supp
# endif
#endif

//!\brief Our char literals returning std::vector should be constexpr if constexpr std::vector is supported.
#if defined(__cpp_lib_constexpr_vector) && __cpp_lib_constexpr_vector >= 201907L
/*!\brief Our char literals returning std::vector should be constexpr if constexpr std::vector is supported.
*
* The _GLIBCXX_DEBUG statement is a workaround for a libstdc++ bug
* \see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104748
* \see https://github.com/seqan/seqan3/issues/3221
SGSSGene marked this conversation as resolved.
Show resolved Hide resolved
* \see https://godbolt.org/z/159n8xrdo
**/
#if __cpp_lib_constexpr_vector >= 201907L && (defined(_LIBCPP_VERSION) || !defined(_GLIBCXX_DEBUG))
# define SEQAN3_WORKAROUND_LITERAL constexpr
#else
# define SEQAN3_WORKAROUND_LITERAL inline
Expand Down
Loading