Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] sam_file_output #3300

Merged
merged 3 commits into from
Nov 7, 2024
Merged

[FIX] sam_file_output #3300

merged 3 commits into from
Nov 7, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Nov 6, 2024

Resolves #3299

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 6, 2024
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3300

@eseiler eseiler force-pushed the fix/sam_file_output branch from 12c77c0 to c53cf15 Compare November 6, 2024 15:28
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 6, 2024
@eseiler eseiler force-pushed the fix/sam_file_output branch from c53cf15 to 1335875 Compare November 6, 2024 15:34
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 6, 2024
@eseiler eseiler marked this pull request as ready for review November 6, 2024 15:39
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (4d03890) to head (5093b36).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3300      +/-   ##
==========================================
- Coverage   98.13%   98.13%   -0.01%     
==========================================
  Files         271      271              
  Lines       11955    11948       -7     
  Branches      104      104              
==========================================
- Hits        11732    11725       -7     
  Misses        223      223

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SGSSGene
Copy link
Contributor

SGSSGene commented Nov 7, 2024

Mega nice! Danke!

@eseiler eseiler force-pushed the fix/sam_file_output branch from 1335875 to 5093b36 Compare November 7, 2024 10:41
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 7, 2024
SGSSGene
SGSSGene approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowing the default c'tors, very good!

@eseiler eseiler merged commit 77db997 into seqan:main Nov 7, 2024
42 checks passed
@eseiler eseiler deleted the fix/sam_file_output branch November 7, 2024 10:52
@feldroop
Copy link
Member

feldroop commented Nov 8, 2024

Awesome, I actually ran into this today!

@tloka
Copy link
Contributor

tloka commented Nov 11, 2024

Finally gained access to my account. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with sam_file_output
5 participants
@eseiler @seqan-actions @SGSSGene @feldroop @tloka