Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Scott Andrews <[email protected]>
  • Loading branch information
scothis committed Mar 3, 2022
1 parent b90efef commit 97b5871
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ rules:

# Service Binding

A Service Binding describes the connection between a [Provisioned Service](#provisioned-service) and a [Workload Projection](#workload-projection). It **MUST** be codified as a concrete resource type with API version `servicebinding.io/v1beta1` and kind `ServiceBinding`. An implementation **MAY** support other version of this specification which define additional API versions. Multiple `ServiceBinding`s can refer to the same service. Multiple `ServiceBinding`s can refer to the same workload. For portability, the schema **MUST** comply to the exemplar CRD found [here][sb-crd].
A Service Binding describes the connection between a [Provisioned Service](#provisioned-service) and a [Workload Projection](#workload-projection). It **MUST** be codified as a concrete resource type with API version `servicebinding.io/v1beta1` and kind `ServiceBinding`. An implementation **MAY** support other versions of this specification which define additional API versions. Multiple `ServiceBinding`s can refer to the same service. Multiple `ServiceBinding`s can refer to the same workload. For portability, the schema **MUST** comply to the exemplar CRD found [here][sb-crd].

Restricting service binding to resources within the same namespace is strongly **RECOMMENDED**. Implementations that choose to support cross-namespace service binding **MUST** provide a security model that prevents attacks like privilege escalation and secret enumeration, as well as a deterministic way to declare target namespaces.

Expand Down Expand Up @@ -450,7 +450,7 @@ status:

# Workload Resource Mapping

A workload resource mapping describes how to apply [service binding](#service-binding) transformations to a [workload projection](#workload-projection). It **MUST** be codified as a concrete resource type (cluster scoped resource) with API version `servicebinding.io/v1beta1` and kind `ClusterWorkloadResourceMapping`. An implementation **MAY** support other version of this specification which define additional API versions. For portability, the schema **MUST** comply to the exemplar CRD found [here][cwrm-crd].
A workload resource mapping describes how to apply [service binding](#service-binding) transformations to a [workload projection](#workload-projection). It **MUST** be codified as a concrete resource type (cluster scoped resource) with API version `servicebinding.io/v1beta1` and kind `ClusterWorkloadResourceMapping`. An implementation **MAY** support other versions of this specification which define additional API versions. For portability, the schema **MUST** comply to the exemplar CRD found [here][cwrm-crd].

A workload resource mapping **MUST** define its name using [CRD syntax][crd-syntax] (`<plural>.<group>`) for the resource that it defines a mapping for. A workload resource mapping **MUST** define a `.spec.versions` which is an array of `MappingTemplate` objects.

Expand Down

0 comments on commit 97b5871

Please sign in to comment.