-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Secret Generation Strategies extension #161
Move Secret Generation Strategies extension #161
Conversation
Since this is our last "extension" should we also remove the whole section? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's make sure there's a concrete issue opened to ensure we don't lose the functionality, at least in an implementation and possibly as a separate spec.
README.md
Outdated
@@ -628,218 +623,3 @@ rules: [] # The control plane automatically fills in the rules | |||
# Extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the entire Extensions section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. 1c03564
I have added the current extension text verbatim to this repository: |
Based on today's call. I have moved the extension into a separate file. |
secret-generation.md
Outdated
@@ -0,0 +1,214 @@ | |||
# Secret Generator Extension for Service Binding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs to be clear that this content is not a required part of the spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a note. I need some help with phrasing it. Here is my attempt:
Note: This spec is dependent on "Service Binding Specification for Kubernetes", but there is no direct association -- neither containment nor aggregation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more sentence pointing to the release cycle:
Note: This spec is dependent on "Service Binding Specification for Kubernetes", but there is no direct association -- neither containment nor aggregation. Both specs are going to have their independent release cycles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we moved it into a directory named "extensions" and added a README.md that contained this paragraph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By and large, this is the issue with keeping placeholder content in the repo. It becomes murky as to what it means and why it exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Created an "extensions" directory and moved the Secret Generation extension inside
- Created "extensions/README.md" with a brief introduction and a table of extensions (No., Title, and Status columns)
- Updated the extension with a brief introduction and status section
Based on the discussion in servicebinding#158 and servicebinding#156, this extension can become a separate standard by itself.
It can be added back again once there is at least one extension.
3652b26
to
edbad80
Compare
Notes from yesterday's meeting:
|
I have created an extensions list in the extensions/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The move looks good, I'm not in a place to judge the content of the extension itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on the discussion in #158 and #156, this extension can become a
separate standard by itself. Move the extension into a separate file.