fix(Xbox): Support screen resolution detection on Xbox when using WebView2 #7144
Conversation
| to be manually added like this when initializing your WebView2: | ||
|
|
||
| ```CSharp | ||
| webView.CoreWebView2.Settings.UserAgent += " Xbox One"; |
There was a problem hiding this comment.
Is there some improvement we could make to UA detection to understand WebView2 as Xbox One without this?
There was a problem hiding this comment.
Based only on the user agent, I don't think it will be possible:
Edge Chromium on Windows 11:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36 Edg/127.0.0.0
WebView2 on Xbox (not modified):
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 Edg/125.0.0.0
They are basically the same, except for the Chrome/Edge version, which is a bit newer on Windows.
Maybe that detecting the presence of the WinRT APIs could be enough. Something like
static isXboxOne() {
return shaka.util.Platform.userAgentContains_('Xbox One') || typeof Windows !== 'undefined' || typeof chrome?.webview?.hostObjects?.sync?.Windows !== 'undefined';
}
But it could still be a UWP running on Windows... Maybe there's a way to get the device type from WinRT once we can access to it.
There was a problem hiding this comment.
Okay, thanks for considering it. We are very open to improvements in detection later.
|
Incremental code coverage: 0.00% |
|
Thank you for contributing, and for writing a good PR description / commit message. It's very helpful. |
Resolves #7141