-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump major versions of client dependencies #529
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bde133a
chore: bump major versions of client dependencies
KhaledEmaraDev 8ad4cab
Refactor js code to pass the lint test
Yassa-hue d160ee8
Add x86_64-linux platform
ahangarha 37bcfca
Upgrade to Shakapacker 7.0.2
ahangarha 6f2fe92
Use generateWebpackConfig instead of webpackConfig
ahangarha 1e30e07
Remove deprecated option
Yassa-hue 4223647
Solve the marked warnings
Yassa-hue 907295a
Move the comment component ref to CommentList
Yassa-hue 8c13893
Fix add comment ref error
Yassa-hue e849ebf
Apply review requests
Yassa-hue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
client/app/bundles/comments/components/CommentBox/CommentBox.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,9 +52,6 @@ export default class CommentList extends BaseComponent { | |
const commentNodes = $$comments.map(($$comment, index) => { | ||
const nodeRef = React.createRef(null); | ||
return ( | ||
// `key` is a React-specific concept and is not mandatory for the | ||
// purpose of this tutorial. if you're curious, see more here: | ||
// http://facebook.github.io/react/docs/multiple-components.html#dynamic-children | ||
<CSSTransition | ||
key={$$comment.get('id') || index} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am concerned that this is a good key. Though it works in our case I think it is better to make ids like |
||
nodeRef={nodeRef} | ||
|
@@ -74,7 +71,7 @@ export default class CommentList extends BaseComponent { | |
// For animation with TransitionGroup | ||
// https://reactcommunity.org/react-transition-group/transition-group | ||
// The 500 must correspond to the 0.5s in: | ||
// client/app/bundles/comments/components/CommentBox/CommentBox.module.scss:6 | ||
// client/app/bundles/comments/components/CommentBox/CommentBox.module.scss:8 | ||
return ( | ||
<div> | ||
{this.errorWarning()} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a linting issue.