Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ledger BCH cashaddr format #640

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: ledger BCH cashaddr format #640

merged 2 commits into from
Oct 18, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 29, 2023 •
edited
Loading

Develop - Native

Screenshot 2023-09-29 at 17 06 20

hdwallet latest published version (consumed in gome)

Screenshot 2023-09-29 at 17 05 52

This diff - note the same format and address as with native

Screenshot 2023-09-29 at 17 06 02

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:59pm

@gomesalexandre Graphite App
Copy link
Contributor Author

gomesalexandre commented Sep 29, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre mentioned this pull request Sep 29, 2023
Merged
@gomesalexandre gomesalexandre changed the title feat: ledger BCH Cash address format feat: ledger BCH cashaddr format Sep 29, 2023
@gomesalexandre gomesalexandre marked this pull request as ready for review September 29, 2023 15:08
@gomesalexandre gomesalexandre mentioned this pull request Sep 29, 2023
Merged
9 tasks
@gomesalexandre gomesalexandre force-pushed the feat_bch_receiveAddr branch 2 times, most recently from 80e379a to 3f8a59d Compare October 3, 2023 06:19
@gomesalexandre gomesalexandre force-pushed the feat_unrug_snaps_integrity branch from 700e32a to ca907c4 Compare October 3, 2023 06:23
@gomesalexandre gomesalexandre mentioned this pull request Oct 4, 2023
Merged
@gomesalexandre gomesalexandre marked this pull request as draft October 9, 2023 13:09
@gomesalexandre gomesalexandre mentioned this pull request Oct 9, 2023
Merged
@gomesalexandre gomesalexandre force-pushed the feat_unrug_snaps_integrity branch from ca907c4 to 8a2cb6a Compare October 9, 2023 20:08
@gomesalexandre gomesalexandre marked this pull request as ready for review October 9, 2023 20:10
Base automatically changed from feat_unrug_snaps_integrity to master October 10, 2023 19:22
@gomesalexandre gomesalexandre mentioned this pull request Oct 11, 2023
Merged
kaladinlight
kaladinlight previously approved these changes Oct 18, 2023
View reviewed changes
@kaladinlight kaladinlight merged commit 1a21bd3 into master Oct 18, 2023
5 checks passed
@kaladinlight kaladinlight deleted the feat_bch_receiveAddr branch October 18, 2023 18:03
0xApotheosis pushed a commit that referenced this pull request Oct 18, 2023
@gomesalexandre @0xApotheosis
feat: ledger BCH cashaddr format (#640)
64fc000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

@woodenfurniture woodenfurniture woodenfurniture left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gomesalexandre @kaladinlight @woodenfurniture