Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: solana native support #702

Merged
merged 29 commits into from
Jan 27, 2025
Merged

feat: solana native support #702

merged 29 commits into from
Jan 27, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 19, 2024 •
edited
Loading

Description

Includes:

  • Isolation layer groundwork
  • Address derivation (working, but with incorrect addresses because of secp256k1 elliptic curve vs. ed25519 Solana uses as a chain)
  • Signing (implemented, but broadcast is failing with Transaction signature verification failure because signing is using secp256k1 signature, which, even if you manage to sign with it, will be nope'd by the node)

TODO:

  • Add ed25519 elliptic curve support to native (most likely a new variant of BIP32 class, which uses ed25519 instead of secp256k1 with current BIP32 class)

Issue

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 7:52pm

@kaladinlight kaladinlight marked this pull request as ready for review January 27, 2025 19:47
@kaladinlight kaladinlight requested a review from a team as a code owner January 27, 2025 19:47
@gomesalexandre gomesalexandre changed the title wip: solana native support feat: solana native support Jan 27, 2025
gomesalexandre
gomesalexandre commented Jan 27, 2025
View reviewed changes
Copy link
Contributor Author

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in web through verdaccio business:

  • Native
image
  • Phantom
image

Also tested signing of swaps and we're looking gucci

https://jam.dev/c/97793b84-7d82-4a54-8f91-04547c29f68b
https://jam.dev/c/ca04a66d-ad6e-4e87-b179-95562e893df3

@kaladinlight kaladinlight merged commit 3412c4c into master Jan 27, 2025
4 checks passed
@kaladinlight kaladinlight deleted the feat_solana_native branch January 27, 2025 21:26
@gomesalexandre gomesalexandre mentioned this pull request Jan 27, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @kaladinlight