-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add solana caip adapters and market data #7798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually looks excellent, though a few missing pieces.
Tested locally, yarn generate:all
regen is sad
@NeOMakinG caip diffs should include actual adapters regen to ensure they're working. While regenerating, I noticed that we're missing:
- import/export of solana adapter in packages/caip/src/adapters/coingecko/generated/index.ts`
- actual adapter JSON (will be automatically generated once you add the below and run
generate:all
script) - solana handling in
parseData
Will test at runtime once added!
scripts/generateAssetData/generateTrustWalletUrl/generateTrustWalletUrl.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Runtime pass
regen:all
script is happy and generated Solana caip adapters / asset data are present in this diff
- Sanity assets check with Solana flag off
https://jam.dev/c/3083913d-e2c7-4901-99e4-d6427a67df8d
Noticed while testing this: typing eth
yields an ENS send option, which is wrong, though also happening in develop
- Sanity assets check with Solana flag on
https://jam.dev/c/43574afe-04c0-4a23-9346-a013aeb870fc
- Solana assets are present with Solana flag on (noticing
chainName
weirdness though disregard it as plugin isn't added yet)
ed15cc7
to
ef1db6d
Compare
Description
We need to add the solana assets using coingecko, it's using CAIP2 to generate the assets.
I also added a flag for Solana so we can disable it at any places like any other chains
It does includes all assets coingecko supports
Also disable any thing not compatible with solana yet such as THORChain quotes
This PR also includes market data for SOL and Solana's assets
Issue (if applicable)
closes #7737
closes #7800
Risk
Low
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)