-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build when deb/* changes #97
base: master
Are you sure you want to change the base?
Conversation
The build calls to Protonmail's repo and builds from it. When that repo changes (i.e. when deb/* changes), the image should be built again. Currently, that repo changed a few days ago, and the "build" image has not updated in a year. I don't see a reason to never update the image when the upstream repo updates frequently.
I think the build from source workflow has been broken since v3 released and hasn't been fixed, all the actions errored. |
@ShayBox @shenxn This patch compiles and produces the images at https://hub.docker.com/r/schklom/protonmail-bridge/tags Note that I do not do the image scan (to avoid issues), i.e. I remove protonmail-bridge-docker/.github/workflows/build.yaml Lines 49 to 68 in 0541f29
|
The build calls to Protonmail's repo and builds from it. When that repo changes (i.e. when deb/* changes), the image should be built again.
Currently, that repo changed a few days ago, and the "build" image has not updated in a year. I don't see a reason to never update the image when the upstream repo updates frequently.