Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

本番環境向けのDockerfileを提供する #1106

Merged
merged 6 commits into from
Dec 2, 2023

Conversation

shibafu528
Copy link
Member

@shibafu528 shibafu528 commented Nov 30, 2023

Tissueを本番実行するためのDockerfileがそろそろ欲しいなと思って作成しました。

リポジトリルートにあるDockerfileは引き続き開発用ということにします。

TODO

  • 動作確認
  • スタートアップ時に storage/ 配下にLaravelの実行上必要なディレクトリを自動作成する機能が欲しいかも

Sorry, something went wrong.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c19f3e2) 38.95% compared to head (41ba06a) 38.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1106   +/-   ##
==========================================
  Coverage      38.95%   38.95%           
  Complexity       887      887           
==========================================
  Files            113      113           
  Lines           3011     3011           
==========================================
  Hits            1173     1173           
  Misses          1838     1838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shibafu528 shibafu528 force-pushed the feature/docker-for-prod branch from faeabea to f6fbed9 Compare November 30, 2023 16:23
@hinaloe
Copy link
Member

hinaloe commented Nov 30, 2023

そういやdockerfileまたぐ時、bakeのcontexts使うとべんりです(always bestではないだろうけど)
https://docs.docker.com/build/bake/build-contexts/

@shibafu528 shibafu528 force-pushed the feature/docker-for-prod branch from ff8ca26 to 41ba06a Compare December 2, 2023 11:19
@shibafu528
Copy link
Member Author

実際に環境作ってみてある程度の動作確認ができたのでマージします。

そういやdockerfileまたぐ時、bakeのcontexts使うとべんりです(always bestではないだろうけど)

知らなかった……こういうのもあるんだ。

@shibafu528 shibafu528 merged commit 8f24583 into develop Dec 2, 2023
@shibafu528 shibafu528 deleted the feature/docker-for-prod branch December 2, 2023 14:15
@shibafu528 shibafu528 mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants