Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade Post Remake troi #3367

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Trade Post Remake troi #3367

wants to merge 7 commits into from

Conversation

Bjarl
Copy link
Contributor

@Bjarl Bjarl commented Sep 15, 2024

About The Pull Request

Remasters the currently removed and unpersoned wasteplanet tradepost map. You have never seen this pr before.
StrongDMM-2024-09-15 19 25 10
StrongDMM-2024-09-15 19 25 13

Why It's Good For The Game

A 'new' ruin of decent quality and some more mapgen options should enrich the experience.

Changelog

🆑 Erika Fox
add: An abandoned tradepost has been located in the system. Investigate nearby waste worlds for more information.
add: preburnt flares
/:cl:

@Bjarl Bjarl requested a review from a team as a code owner September 15, 2024 23:29
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Code change Watch something violently break. labels Sep 15, 2024
Copy link
Member

@thgvr thgvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has far too many unrelated changes

code/datums/mapgen/planetary/WasteGenerator.dm Outdated Show resolved Hide resolved
_maps/shuttles/syndicate/syndicate_cybersun_kansatsu.dmm Outdated Show resolved Hide resolved
code/modules/clothing/outfits/factions/solgov.dm Outdated Show resolved Hide resolved
code/modules/mining/equipment/marker_beacons.dm Outdated Show resolved Hide resolved

//inteq

/obj/effect/mob_spawn/human/corpse/inteq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really want stocked corpses in a ruin like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would you suggest trimming it down to?

"conc_tiles"
))

/turf/open/floor/concrete/wasteplanet/MakeSlippery(wet_setting, min_wet_time, wet_time_to_add, max_wet_time, permanent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is specifically wasteplanet concreate not slippery

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasteplanets can spawn with water vapor in the atmosphere (unless this has been changed. I did not check), and having a biome turn into a giant slip and slide doesn't sound like an engaging gameplay experience.

@Bjarl Bjarl requested a review from thgvr September 16, 2024 18:52
@FalloutFalcon FalloutFalcon added the Ruin Ruin successfully tested. label Sep 20, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 20, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 23, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants