Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analgesia Trait + Stuff For It To Work #3369

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Bjarl
Copy link
Contributor

@Bjarl Bjarl commented Sep 15, 2024

About The Pull Request

Adds a trait, "congenital analgesia". Analgesia makes it so you don't process pain like other people do. This is reflected through silencing most of your screams, occasionally giving you different fluff text, and making it so you don't know your health.
Morphine and other fluff painkillers have a slighter version of this effect.

Why It's Good For The Game

Fluff. RP. Trait.

Changelog

🆑
add: Reports of people inflicted with congenital analgesia travelling to the Frontier have reached this newscaster.
add: Painkillers may circumvent pain in some cases now.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 15, 2024
Copy link
Member

@thgvr thgvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really have a pain system, and I kinda dislike quirks as is, so this feels very strange to add

@Orchidthederg
Copy link
Contributor

I think it mostly applies to things like broken bone events (dropping items, losing control of limbs, etc.) and surgery

@Bjarl
Copy link
Contributor Author

Bjarl commented Sep 16, 2024

I walked through it as an excuse to constantly have no "good" read on your health, and the pain stuff felt like a natural progression from there (if a bit tacked)

Comment on lines 1211 to 1212
if(!HAS_TRAIT(victim, TRAIT_ANALGESIA))
INVOKE_ASYNC(victim, TYPE_PROC_REF(/mob, emote), "scream")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just call force scream here

Comment on lines 660 to 663
var/mob/living/carbon/human/H = quirk_holder
if(H.hal_screwyhud != SCREWYHUD_HEALTHY)
H.set_screwyhud(SCREWYHUD_HEALTHY)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of constantly checking if you still have the thing add a check in set_screwyhud to prevent something from overwriting the quirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants