Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Golang 1.20 #1351

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Update to Golang 1.20 #1351

merged 1 commit into from
Aug 7, 2023

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Golang 1.21 is expected to be released this month. Then, 1.19 is out of support. Therefore, it is time to move up to 1.20.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Golang 1.20 is used to compile

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Aug 5, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Aug 5, 2023
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Aug 5, 2023
@qu1queee qu1queee self-requested a review August 7, 2023 06:58
qu1queee
qu1queee approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1156efa into main Aug 7, 2023
13 checks passed
@openshift-merge-robot openshift-merge-robot deleted the sascha-golang-1.20 branch August 7, 2023 07:01
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Feb 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SaschaSchwarze0 @qu1queee @openshift-merge-robot