Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Golang 1.20 #1351

Merged
merged 1 commit into from
Aug 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: '1.19.x'
go-version: '1.20.x'
cache: true
check-latest: true
- name: Build
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: '1.19.x'
go-version: '1.20.x'
cache: true
check-latest: true
- name: Install Ko
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: '1.19.x'
go-version: '1.20.x'
cache: true
check-latest: true
- name: Install kubectl
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/mirror-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
library/golang:1.17 \
library/golang:1.18 \
library/golang:1.19 \
library/golang:1.20 \
library/maven:3-jdk-8-openj9 \
library/node:12 \
library/node:14 \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: '1.19.x'
go-version: '1.20.x'
cache: true
check-latest: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
fetch-depth: 0 # Fetch all history, needed for release note generation.
- uses: actions/setup-go@v3
with:
go-version: '1.19.x'
go-version: '1.20.x'
cache: true
check-latest: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: '1.19.x'
go-version: '1.20.x'
cache: true
check-latest: true
cache-dependency-path: go/src/github.com/shipwright-io/build
Expand Down
2 changes: 1 addition & 1 deletion HACK.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ In the near future, the above would be setup by the controller.
make clean && make build
```

* This project uses Golang 1.19+ and controller-gen v0.10.0.
* This project uses Golang 1.20 and controller-gen v0.10.0.
* The controllers create/watch Tekton objects.

# Testing
Expand Down
2 changes: 1 addition & 1 deletion docs/buildstrategies.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ The build strategy provides the following parameters that you can set in a Build
| Parameter | Description | Default |
| -- | -- | -- |
| `go-flags` | Value for the GOFLAGS environment variable. | Empty |
| `go-version` | Version of Go, must match a tag from [the golang image](https://hub.docker.com/_/golang?tab=tags) | `1.19` |
| `go-version` | Version of Go, must match a tag from [the golang image](https://hub.docker.com/_/golang?tab=tags) | `1.20` |
| `ko-version` | Version of ko, must be either `latest` for the newest release, or a [ko release name](https://github.com/ko-build/ko/releases) | `latest` |
| `package-directory` | The directory inside the context directory containing the main package. | `.` |
| `target-platform` | Target platform to be built. For example: `linux/arm64`. Multiple platforms can be provided separated by comma, for example: `linux/arm64,linux/amd64`. The value `all` will build all platforms supported by the base image. The value `current` will build the platform on which the build runs. | `current` |
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/shipwright-io/build

go 1.19
go 1.20

require (
github.com/docker/cli v24.0.5+incompatible
Expand Down
2 changes: 1 addition & 1 deletion samples/build/build_ko_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
- name: go-flags
value: "-v -mod=vendor -ldflags=-w"
- name: go-version
value: "1.19"
value: "1.20"
- name: package-directory
value: ./cmd/shipwright-build-controller
source:
Expand Down
2 changes: 1 addition & 1 deletion samples/buildstrategy/ko/buildstrategy_ko_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
default: ""
- name: go-version
description: "Version of Go, must match a tag from https://hub.docker.com/_/golang?tab=tags"
default: "1.19"
default: "1.20"
- name: ko-version
description: "Version of ko, must be either 'latest', or a release name from https://github.com/ko-build/ko/releases"
default: latest
Expand Down