Reliably detect evicted pods for failing BuildRuns #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
/assign HeavyWombat |
openshift-ci
bot
added
release-note
SaschaSchwarze0
requested changes
Oct 4, 2023
pull-request-size
bot
added
size/S
openshift-ci
bot
added
lgtm
When a BuildRun pod is failing it is not necessary to check for failedContainer first. We can directly check if the pod is evicted and reflect that in the BuildRun condition Depending on how the system is evicting the pod, `extractFailedPodAndContainer` might return a non-nil value for `failedContainer`. In such scenarios we were not detecting if the pod was evicted. This is now fixed as we first check the Reason
|
verify failed as I missed the linter directive to ignore the deprecation notice. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee, SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a BuildRun pod is failing it is not necessary to check for failedContainer first.
We can directly check if the pod is evicted and reflect that in the BuildRun condition
Depending on how the system is evicting the pod,
extractFailedPodAndContainermight return a non-nil value forfailedContainer.In such scenarios we were not detecting if the pod was evicted.
This is now fixed as we first check the Reason
Submitter Checklist
Release Notes