Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliably detect evicted pods for failing BuildRuns #1390

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Reliably detect evicted pods for failing BuildRuns #1390

merged 1 commit into from
Oct 5, 2023

Commits on Oct 5, 2023

  1. Reliably detect evicted pods for failing BuildRuns 

    When a BuildRun pod is failing it is not necessary to check for failedContainer first.
We can directly check if the pod is evicted and reflect that in the BuildRun condition
Depending on how the system is evicting the pod, `extractFailedPodAndContainer` might return a non-nil value for `failedContainer`.
In such scenarios we were not detecting if the pod was evicted.
This is now fixed as we first check the Reason
    @isibeni
    isibeni committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3217795 View commit details
    Browse the repository at this point in the history