[16.0][MIG] shopinvader_lead: Migration to 16.0 #1405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusaison
force-pushed
the
16.0-mig-shopinvader_api_lead
branch
from
69e6a6f to
1d7ab2d
Compare
matthieusaison
force-pushed
the
16.0-mig-shopinvader_api_lead
branch
from
1d7ab2d to
0f9e1db
Compare
| contact_name: str | None = None | ||
|
|
||
|
|
||
| # # faire un module supp pour ces champs |
There was a problem hiding this comment.
TODO add a module: shopinvader_api_lead_firstname
| else: | ||
| self.assertEqual(lead[key], check_data[key]) | ||
| # TODO split shopinvader tests.test_notification | ||
| # self._check_notification("lead_confirmation", lead) |
|
Hi @matthieusaison , @sebastienbeau Mine is less complete than yours, because our customer only needs a really simple service. But the addon can then evolve if you still need it. |
|
PR have been merged here #1525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need this PR to pass test:
OCA/rest-framework#373