Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] shopinvader_api_lead: FastAPI service for creating CRM leads #1525

Merged

Conversation

marielejeune
Copy link
Contributor

@marielejeune marielejeune commented Mar 29, 2024

Adding a new lead_router and a new service to create CRM leads.
This addon is now very simple, as it just adds few info: email, subject, description. We don't need anything more for our customer, but this addon can evolve following the community's needs.

@marielejeune marielejeune marked this pull request as draft March 29, 2024 13:07
@marielejeune marielejeune force-pushed the 16.0-shopinvader_api_lead-mle branch from d8b543e to d31c7a3 Compare March 29, 2024 13:10
@marielejeune marielejeune marked this pull request as ready for review March 29, 2024 13:20
@marielejeune marielejeune force-pushed the 16.0-shopinvader_api_lead-mle branch from d31c7a3 to c7729a1 Compare April 16, 2024 06:50
@marielejeune marielejeune force-pushed the 16.0-shopinvader_api_lead-mle branch from c7729a1 to 7bb0cbc Compare April 16, 2024 07:01
@sebastienbeau sebastienbeau added this to the 16.0 milestone Jun 3, 2024
@sebastienbeau
Copy link
Contributor

There is already a PR for the lead here : #1405

The main difference is the fields available.

On the previous version more field where available :

def _validator_create(self):

On the other PR the list is here : https://github.com/shopinvader/odoo-shopinvader/pull/1405/files#diff-4384e51893bb83e7bdf819ff2e8d1c698a694dcf88df6e075c05d0eb05537cfdR4



class Lead(StrictExtendableBaseModel):
id: int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the missing fields

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to make a new PR to add these missing fields

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@sebastienbeau
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1525-by-sebastienbeau-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit bca4463 into shopinvader:16.0 Jun 4, 2024
3 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 4413a7c. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 16.0-shopinvader_api_lead-mle branch June 4, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants