Addressed review comments

shripad621git · Feb 15, 2024 · bf39f12 · bf39f12
1 parent b2f77b3
commit bf39f12
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/config/esp32/components/chip/Kconfig b/config/esp32/components/chip/Kconfig
@@ -913,11 +913,15 @@ menu "CHIP Device Layer"
            help
                This option enables the system statistics to be sent to the insights cloud.
 
-      config INSIGHTS_TRACE_PERMIT_LIST_SIZE
-           int "Config option to set permitlist size"
+      config MAX_PERMIT_LIST_SIZE
+           int "Set permit list size for Insights traces"
            range 5 30
            depends on ESP_INSIGHTS_ENABLED
            default 20
+           help
+               Maximum number of group entries that can be included in the permit list for reporting
+               the traces to insights.
+
     endmenu
 
 

diff --git a/src/tracing/esp32_trace/esp32_tracing.cpp b/src/tracing/esp32_trace/esp32_tracing.cpp
@@ -30,7 +30,7 @@ namespace Tracing {
 namespace Insights {
 namespace {
 
-constexpr size_t kPermitListMaxSize = CONFIG_INSIGHTS_TRACE_PERMIT_LIST_SIZE;
+constexpr size_t kPermitListMaxSize = CONFIG_MAX_PERMIT_LIST_SIZE;
 using HashValue                     = uint32_t;
 
 // Implements a murmurhash with 0 seed.