Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation for Maurizio's gnome-screenshot hack #667

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Photon89
Copy link
Member

@Photon89 Photon89 commented Apr 1, 2024

Currently only the Selection mode works. Also, the Selection button is always enabled.

What it does: creates a file in /tmp using gnome-screenshot, then creates a pixbuf out of this file and proceeds as usual.

TODO:

  • including the mouse cursor for selection: upstream bug
  • hide_time needs to be implemented
  • redo screenshot doesn't work either
  • fullscreen mode
  • window mode
  • conditionally disable unavailable modes' buttons
  • show warning if gnome-screenshot is missing in Gnome
  • remove unnecessary methods

}


sub redo_capture {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't actually redo any capture, will it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this is just a remainder from the SelectorAdvance.pm module which I took as a base. I have some ideas, how redo could be possible (make a full screen screenshot with gnome-screenshot, then choose the proper area, but this would require to somehow get the information, what the proper area is, as now gnome-screenshot is responsible for doing the selection) but nothing working yet.

sub quit {
my $self = shift;

$self->ungrab_pointer_and_keyboard(FALSE, FALSE, TRUE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it grab them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another unnecessary remainder.

@Photon89
Copy link
Member Author

Photon89 commented Apr 2, 2024

gnome-screenshot has a bug, apparently, which prevents it from capturing the pointer in selection mode. I reported it upstream: https://gitlab.gnome.org/GNOME/gnome-screenshot/-/issues/244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants