-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplementation for Maurizio's gnome-screenshot hack #667
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
|
||
sub redo_capture { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't actually redo any capture, will it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is just a remainder from the SelectorAdvance.pm module which I took as a base. I have some ideas, how redo could be possible (make a full screen screenshot with gnome-screenshot, then choose the proper area, but this would require to somehow get the information, what the proper area is, as now gnome-screenshot is responsible for doing the selection) but nothing working yet.
sub quit { | ||
my $self = shift; | ||
|
||
$self->ungrab_pointer_and_keyboard(FALSE, FALSE, TRUE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it grab them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another unnecessary remainder.
share/shutter/resources/modules/Shutter/Screenshot/SelectorGnomeWayland.pm
Outdated
Show resolved
Hide resolved
gnome-screenshot has a bug, apparently, which prevents it from capturing the pointer in selection mode. I reported it upstream: https://gitlab.gnome.org/GNOME/gnome-screenshot/-/issues/244 |
Currently only the Selection mode works. Also, the Selection button is always enabled.
What it does: creates a file in /tmp using gnome-screenshot, then creates a pixbuf out of this file and proceeds as usual.
TODO: