Various fixes around the extensions lifecycle on Chrome / Chromium #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kiszka
approved these changes
Jul 2, 2024
These functions are non async anyways, hence there is no need to make them async. By that, we also can use them directly in the handler instead of wrapping in a lambda. Signed-off-by: Felix Moessbauer <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
On chrome and chromium, the native part is not reliably terminated when the browser is terminated. As we also cannot reliably send a message to the host part on termination of the browser, there is no direct way to let the host script known. In theory, the script should terminate once stdio is closed, but in practice this is not always the case, leading to orphaned processes. To fix this, we use prctl to register a PDEATHSIG handler. Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/fix-lifecycle-chrome
branch
from
c7d5ae5
to
7b60438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the host-part double initialization and non-termination issues on Chrome and Chromium.