Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes around the extensions lifecycle on Chrome / Chromium #8

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Various fixes around the extensions lifecycle on Chrome / Chromium #8

merged 3 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. refactor: make startup-handler non-async 

    These functions are non async anyways, hence there is no need to make
them async. By that, we also can use them directly in the handler
instead of wrapping in a lambda.

Signed-off-by: Felix Moessbauer <[email protected]>
    @fmoessbauer
    fmoessbauer committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    664490f View commit details
    Browse the repository at this point in the history

  2. fix: make startup atomic to avoid double-initialization on chrome 

    Signed-off-by: Felix Moessbauer <[email protected]>
    @fmoessbauer
    fmoessbauer committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f021a77 View commit details
    Browse the repository at this point in the history

  3. fix: always terminate host component when browser is terminated 

    On chrome and chromium, the native part is not reliably terminated when
the browser is terminated. As we also cannot reliably send a message to
the host part on termination of the browser, there is no direct way to
let the host script known. In theory, the script should terminate once
stdio is closed, but in practice this is not always the case, leading to
orphaned processes.

To fix this, we use prctl to register a PDEATHSIG handler.

Signed-off-by: Felix Moessbauer <[email protected]>
    @fmoessbauer
    fmoessbauer committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7b60438 View commit details
    Browse the repository at this point in the history