Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Dispatch patch tag workflow instead of running directly #139

Merged

Conversation

GuySartorelli
Copy link
Member

Dispatches the new workflow added in silverstripe/module-standardiser#66 instead of running patch tagging directly.

This removes the need for content:write permissions in ci.yml

Issue

@GuySartorelli
Copy link
Member Author

Note that https://github.com/GuySartorelli/issue-template-playground/actions/runs/10153987547/job/28078370071 shows the workflow fails when the actions: write permission is missing, and https://github.com/GuySartorelli/issue-template-playground/actions/runs/10154036879/job/28078504318 shows it works when that permission is provided.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/1/dispatch-patch branch from e2e1368 to cbaefcc Compare July 31, 2024 21:58
Comment on lines +38 to +31
permissions:
pull-requests: read
contents: read
Copy link
Member Author

@GuySartorelli GuySartorelli Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the fact that CI there is still red - that's just 'cause there's nothing for generate-matrix to output for that repo, and CI doesn't like having no matrix when it's told there will be one.

I also tested these permissions in a repo that actually does get a generated matrix and it works as expected, red job not-withstanding

README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/1/dispatch-patch branch 2 times, most recently from 52a34d0 to 95cf4d1 Compare August 1, 2024 23:31
@GuySartorelli GuySartorelli force-pushed the pulls/1/dispatch-patch branch from 95cf4d1 to 250867c Compare August 4, 2024 22:34
@GuySartorelli
Copy link
Member Author

Rebased so CI passes in my repo (needed the chromedriver fix)

@emteknetnz emteknetnz merged commit 1e21f9a into silverstripe:1 Aug 5, 2024
4 checks passed
@emteknetnz emteknetnz deleted the pulls/1/dispatch-patch branch August 5, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants