Update wrap up move command and change all moves to single command #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmharrington
requested changes
Dec 10, 2024
There was a problem hiding this comment.
I like removing the double-move commands but this is missing something for actual implementation. We don't actually want to always stow at the end of a schedule if the next one would be going straight into CMB maps.
I just tried running a schedule for satp2 that ended at 11:00 UTC (so away from sun safety time) and it turned off the HWP and stowed whether or not I had home_at_end set to True.
…n setup, force waiting until sun-safe
kmharrington
approved these changes
Dec 12, 2024
This was
linked to
issues
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to address #96 by removing the move command from the
sat.wrap_upoperation and treating the post-session IR as a regular block similar to cmb or source scans. This should also address #122, by removing the 2 individual az-only or el-only move commands and making a single az/el move for all move commands.