Fixes/duplicate nil field #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even when empty We also test that when you duplicate an empty multiple field you get another empty multiple field
This way we avoid connectionsto an unexisting API
…ecord Beware! In this commit I overwrite behaviour introduced by @enoliglesias in d8214e6 relying more in the super behaviour and only rewriting the :link case when there's something to link. I think I got the idea of the original code and kept it correctly, and tests are green. But maybe @enoliglesias can review this :)
|
@Guzmangm you were assigned to this pull request as you knew the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the issue with trying to duplicate (with :dup) an ActiveRecord / ActiveResource field that is nil