Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/duplicate nil field #23

Open
wants to merge 9 commits into
base: edge
Choose a base branch
from
Open

Fixes/duplicate nil field #23

wants to merge 9 commits into from

Commits on Oct 4, 2016

  1. Hrouping specs in context in a more meaningful way

    @brenes
    brenes committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    f7fc582 View commit details
    Browse the repository at this point in the history

  2. New model without validations for testing the duplicate nil scenario

    @brenes
    brenes committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    74ec7e5 View commit details
    Browse the repository at this point in the history

  3. Checking that empty multiple fields return an ActiveRecord::Relation … 

    …even when empty

We also test that when you duplicate an empty multiple field you get another empty multiple field
    @brenes
    brenes committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    0b32efe View commit details
    Browse the repository at this point in the history

  4. extracted the id_field login to a helper method

    @brenes
    brenes committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    aa6b632 View commit details
    Browse the repository at this point in the history

  5. Fixing the bug creating new objects from nil ones when dupping

    @brenes
    brenes committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    877da48 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2016

  1. Mocking find methods in ActiveResource test model 

    This way we avoid connectionsto an unexisting API
    @brenes
    brenes committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    2a4c352 View commit details
    Browse the repository at this point in the history

  2. Mocking build and save calls in the ActiveResource model

    @brenes
    brenes committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    45e6039 View commit details
    Browse the repository at this point in the history

  3. extracting the id field method to the base multiple serializer

    @brenes
    brenes committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    7d255b6 View commit details
    Browse the repository at this point in the history

  4. Testing with ActiveResource all scenarios that were tested in ActiveR… 

    …ecord

Beware! In this commit I overwrite behaviour introduced by @enoliglesias in d8214e6 relying more in the super behaviour and only rewriting the :link case when there's something to link.

I think I got the idea of the original code and kept it correctly, and tests are green. But maybe @enoliglesias can review this :)
    @brenes
    brenes committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    1ec398f View commit details
    Browse the repository at this point in the history