DEVEXP-337: Mocked tests setup #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
asein-sinch
commented
Jun 26, 2024
asein-sinch
commented
- Cucumber configuration
- Steps implementation for Fax.Faxes domain as a POC
- CI configuration to put the feature files in the right folder and run the cucumber tests
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
JPPortier
reviewed
Jun 27, 2024
| mkdir -p ./packages/fax/tests/e2e/features | ||
| - name: Copy feature files | ||
| run: | | ||
| cp sinch-sdk-mockserver/features/fax/*.feature ./packages/fax/tests/e2e/features/ |
There was a problem hiding this comment.
Is it having sense to add the feature files onto Docker image and access them from container when mounted ? (docker compose volumes usage)
PROS:
- all requirements for e2e are stored within a single image and used from mounted container. So if image could from a hub, there is no longer dependency onto another repository
- in case of refactoring from source image repository (aggregation, doc, comments, ...) the "public availability" for feature will be by contracts onto "/features" container's directory and could be curated during image creation
There was a problem hiding this comment.
The destination folder has to match the Cucumber configuration. If we say to Cucumber to read from the docker volume, that's fine too. As we don't have an artifact repositoty to rely on for the moment, cloning the docker-compose file and the features is the simplest solution that came into my mind in a spirit of sharing the mockserver expectations and cucumber features across the SDKs
JPPortier
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.