Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVEXP-337: Mocked tests setup #97
DEVEXP-337: Mocked tests setup #97
Changes from all commits
38fde50
48e7956
57c35ff
4a326c7
7e91a35
00bb897
3fa1b51
12bdf8d
d2f566d
3f83613
8d19343
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it having sense to add the feature files onto Docker image and access them from container when mounted ? (docker compose
volumes
usage)PROS:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The destination folder has to match the Cucumber configuration. If we say to Cucumber to read from the docker volume, that's fine too. As we don't have an artifact repositoty to rely on for the moment, cloning the docker-compose file and the features is the simplest solution that came into my mind in a spirit of sharing the mockserver expectations and cucumber features across the SDKs