Switch replication methods #173
Conversation
| self.assertTrue(fulltbl_primary_keys.issubset(incrmntl_primary_keys)) | ||
|
|
||
| #verify that the last message is not a activateversion message for incremental sync | ||
| self.assertNotEqual('activate_version', incrmntl_sync_records[stream]['messages'][-1]['action']) |
There was a problem hiding this comment.
The activate_version message tells the loaders it is okay to go ahead and load data into the table. If we have sent all of the data, it is okay to start loading. So although this message may not be necessary, it would have no negative consequences.
Also, If they take the appropriate action and fix it so that they do not send the activate_version as the first message for a new table version for incremental, waiting until all data is ready before deleting the previous full table records, Then it would be necessary/critical to have this message be sent.
So in the final version we should assert that the only the last message is an activate version, and as a workaround we should verify that there is an activate message being sent.
There was a problem hiding this comment.
Added a qa task in the DOD of the ticket to modify the assertions based on the final implementation.
| self.assertEqual('activate_version', fulltbl_sync_records[stream]['messages'][fulltbl_sync_count+1] | ||
| ['action']) |
There was a problem hiding this comment.
Also, the same comment as above. I think we should expect this and also when the ticket is fixed assert that there is no other message that is an activate_version message. We should probably write out that assertion that will fail and comment it out with a comment mentioning the ticket that will address the issue.
There was a problem hiding this comment.
For the activate version, added a qa task/note in the ticket itself in the DOD to add or m,odify the assertions based on the final implementation.
| #verify that the table version incremented after every sync | ||
| self.assertGreater(incrmntl_sync_records[stream]['table_version'], | ||
| fulltbl_sync_records[stream]['table_version'], | ||
| msg = "Table version is not incremented after a successful sync") |
Co-authored-by: bhtowles <[email protected]>
Co-authored-by: bhtowles <[email protected]>
Co-authored-by: bhtowles <[email protected]>
Co-authored-by: bhtowles <[email protected]>
Description of change
Switching replication method from full_table to incremental and vice versa
QA steps
Risks
low
Rollback steps