Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch replication methods #173
Switch replication methods #173
Changes from all commits
1405907
33b5f96
eeed6f3
f2d7ac6
5498013
1fb1e0e
0904574
4619737
bbd5723
d60fb1f
d87cc90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The activate_version message tells the loaders it is okay to go ahead and load data into the table. If we have sent all of the data, it is okay to start loading. So although this message may not be necessary, it would have no negative consequences.
Also, If they take the appropriate action and fix it so that they do not send the activate_version as the first message for a new table version for incremental, waiting until all data is ready before deleting the previous full table records, Then it would be necessary/critical to have this message be sent.
So in the final version we should assert that the only the last message is an activate version, and as a workaround we should verify that there is an activate message being sent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a qa task in the DOD of the ticket to modify the assertions based on the final implementation.