TASK: Use deepObject for all non trivial parameters and remove [] from collection names
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ValueObjects use style deepObject instead of form
…l use deepObject style now
mficzel
force-pushed
the
task/useDeepObjectForAllNonTrivialParameters
branch
from
36fd249
to
6d31435
Compare
nezaniel
requested changes
Jun 17, 2024
| $this->assertEquals($isSVDTO, IsSingleValueDataTransferObject::isSatisfiedByClassName($className), sprintf('IsSingleValueDataTransferObject should return "%s" for class "%s"', $isSupported ? 'true' : 'false', $className)); | ||
| } | ||
|
|
||
| public function testFoo(): void |
There was a problem hiding this comment.
This is obsolete because already covered in the last test case from above, right?
There was a problem hiding this comment.
Correct. During cleanup this was too far at the end to be noticed.
There was a problem hiding this comment.
removed the obsolete test will merge now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use style deepObject for all QueryParameters that are not scalar or singleValueValueObjects.
also: