[Core] Allow override env for all task in dag #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Romil Bhardwaj <[email protected]>
…o override-env-for-all-task-in-dag
|
Also I noticed a typo: Line 35 in ea5aa50 --gpus instead of --gpu. Can we also include that fix in this PR?
|
romilbhardwaj
approved these changes
May 31, 2024
There was a problem hiding this comment.
Thanks @Michaelvll! Ran some manual tests to check envvar behavior, lgtm.
| mode: COPY | ||
|
|
||
| setup: | | ||
| cd ~ | ||
| pip install tqdm tiktoken requests datasets |
There was a problem hiding this comment.
Yes, it is not needed for training stage, but only for the data processing stage : )
Co-authored-by: Romil Bhardwaj <[email protected]>
cblmemo
approved these changes
May 31, 2024
There was a problem hiding this comment.
Thanks for adding this feature @Michaelvll ! It looks good to me ;) I'm wondering if we need to clarify this semantic changes in the documentation, but we could do it in another PR as well. Maybe left an TODO or file an issue for this if we decided to delay it?
…/skypilot-org/skypilot into override-env-for-all-task-in-dag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by #3611, as we should be able to propagate the secrets / envs across all the tasks, allowing
sky jobs launch gpt2-pipeline.yaml --env BUCKET_NAME=my-bucket-nameTested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh