Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow override env for all task in dag #3623

Merged
merged 41 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
374f0f2
add gpt-2 example
Michaelvll May 28, 2024
79323f7
Use ubuntu for GCP
Michaelvll May 29, 2024
03623ee
fix ncl
Michaelvll May 29, 2024
3636ea6
Fix GPT-2
Michaelvll May 29, 2024
1694ecd
add train and data
Michaelvll May 29, 2024
2c80dcb
use 8 gpus
Michaelvll May 29, 2024
1bef798
revert gcp change
Michaelvll May 29, 2024
9282873
update readme
Michaelvll May 29, 2024
0ee942c
Add GCP image
Michaelvll May 29, 2024
5af0d93
make file_mounts more general
Michaelvll May 29, 2024
71bcdd0
avoid any_of
Michaelvll May 29, 2024
488347f
change back to use ubuntu image with wait for GPU
Michaelvll May 30, 2024
8ec06a8
Merge branch 'gpt-2' of https://github.com/skypilot-org/skypilot into…
Michaelvll May 30, 2024
2e5bacf
wait cuda installation
Michaelvll May 30, 2024
c070da0
Add retry for file mount and use env for bucket name
Michaelvll May 30, 2024
87d2a3c
revert retries
Michaelvll May 30, 2024
d6e9554
update the image
Michaelvll May 30, 2024
0c2d799
Merge branch 'master' of https://github.com/skypilot-org/skypilot int…
Michaelvll May 30, 2024
ef26ecd
change to docker for better dependency
Michaelvll May 30, 2024
2b0a085
revert changes in gcp template
Michaelvll May 30, 2024
aa8ecfe
avoid using docker on lambda
Michaelvll May 30, 2024
265e43c
Add single GPU
Michaelvll May 30, 2024
598dca5
Elaborate readme
Michaelvll May 30, 2024
3056c2c
Update llm/gpt-2/README.md
Michaelvll May 30, 2024
815d23c
fix
Michaelvll May 30, 2024
faf63d8
Merge branch 'gpt-2' of https://github.com/skypilot-org/skypilot into…
Michaelvll May 30, 2024
4c44935
address comments
Michaelvll May 31, 2024
3b7312e
Fix data fetching
Michaelvll May 31, 2024
b6566d7
Add visualization
Michaelvll May 31, 2024
bea72d5
update
Michaelvll May 31, 2024
8887435
reduce cpu cost
Michaelvll May 31, 2024
7609990
update loss curve
Michaelvll May 31, 2024
3b64913
Fill in env for all task in dag
Michaelvll May 31, 2024
fb4efe1
Merge branch 'master' of https://github.com/skypilot-org/skypilot int…
Michaelvll May 31, 2024
5ca4e48
address comments
Michaelvll May 31, 2024
a939ba0
fix
Michaelvll May 31, 2024
adc9592
fix
Michaelvll May 31, 2024
a2c0409
add bucket store
Michaelvll May 31, 2024
e7ae29d
Update llm/gpt-2/README.md
Michaelvll May 31, 2024
ca70b2f
address
Michaelvll May 31, 2024
9a8dbe4
Merge branch 'override-env-for-all-task-in-dag' of https://github.com…
Michaelvll May 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sky/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,8 @@ def _make_task_or_dag_from_entrypoint_with_overrides(
f'WARNING: override params {override_params} are ignored, '
'since the yaml file contains multiple tasks.',
fg='yellow')
for task in dag.tasks:
task.update_envs(env)
Michaelvll marked this conversation as resolved.
Show resolved Hide resolved
return dag
assert len(dag.tasks) == 1, (
f'If you see this, please file an issue; tasks: {dag.tasks}')
Expand Down
6 changes: 0 additions & 6 deletions sky/utils/dag_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,6 @@ def load_chain_dag_from_yaml(
# YAML has only `name: xxx`. Still instantiate a task.
configs = [{'name': dag_name}]

if len(configs) > 1:
# TODO(zongheng): in a chain DAG of N tasks, cli.py currently makes the
# decision to not apply overrides. Here we maintain this behavior. We
# can listen to user feedback to change this.
env_overrides = None
Michaelvll marked this conversation as resolved.
Show resolved Hide resolved

current_task = None
with dag_lib.Dag() as dag:
for task_config in configs:
Expand Down
Loading