Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Fix best disk tier on AWS to use the best IOPS #3836

Closed
wants to merge 1 commit into from

Conversation

romilbhardwaj
Copy link
Collaborator

AWS supports upto 16000 IOPS and 1000MB/s throughput on GP3. We should use those specs for high disk tier. Makes a significant difference for reading models/datasets.

Benchmarks:
Before, --disk-tier best on AWS:

(storage-demo, pid=29191) ##### Sequential Read Results #####
(storage-demo, pid=29191) EBS:  498.37 MB/s     7604.55 IOPS
(storage-demo, pid=29191) 
(storage-demo, pid=29191) ##### Sequential Write Results #####
(storage-demo, pid=29191) EBS:  485.97 MB/s     7415.25 IOPS

After, --disk-tier best on AWS:

(storage-demo, pid=30375) ##### Sequential Read Results #####
(storage-demo, pid=30375) EBS:  1395.38 MB/s    21291.75 IOPS
(storage-demo, pid=30375) 
(storage-demo, pid=30375) ##### Sequential Write Results #####
(storage-demo, pid=30375) EBS:  1215.33 MB/s    18544.43 IOPS

@@ -799,7 +799,7 @@ def _get_disk_specs(
disk_tier: Optional[resources_utils.DiskTier]) -> Dict[str, Any]:
tier = cls._translate_disk_tier(disk_tier)
tier2iops = {
resources_utils.DiskTier.HIGH: 7000,
resources_utils.DiskTier.HIGH: 16000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous IOPS was selected to keep the HIGH disk tier's performance for all clouds similar to each other. Should we instead create a new DiskTier.ULTRA for the max possible IOPS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. How about we change DiskTier.BEST to the actual best possible disk tier?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, BEST is the best DiskTier among LOW, MEDIUM, HIGH provided by SkyPilot right now (some clouds may not have HIGH tier, so BEST will map to MEDIUM in that case).

I am fine with changing the semantics of BEST to the actual best disk available on a specific cloud. This is related to #3585 and #3517.

@Michaelvll
Copy link
Collaborator

This should be fixed by #3860. Closing for now.

@Michaelvll Michaelvll closed this Sep 5, 2024
@Michaelvll Michaelvll deleted the aws_disktiers branch December 18, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants